React-datepicker: Latest version does not open popup inside table

Created on 10 Jul 2017  路  13Comments  路  Source: Hacker0x01/react-datepicker

It seems like migration to popper.js broke popup position.
I think it has something related to https://github.com/FezVrasta/popper.js/issues/276

wontfix

Most helpful comment

I am also having issue as a result of switching from tether to popper

All 13 comments

I'd love to get this fixed. It shouldn't be a complex bug. But for personal reasons I'm going to be away from PC for some time. If someone could come up with a PR it would be awesome.

I am also having issue as a result of switching from tether to popper

To clarify for future reference, the version under discussion is 0.49 and this change:

  • Migrate from tether.io to popper.js for handling calendar popups

Workaround: Revert back to 0.48 for the mean time.

@evolve2k I cannot because it fails in Jest test with: Invariant Violation: getNodeFromInstance: Invalid argument.

the table bug should be fairly easy to fix if anyone wants to give it a shot in the Popper.js repo

This project is using "react-popper", not "popper.js" by FezVrasta (which should have solved this problem since 1.11.0).

react-popper depends on popper.[email protected] so you are able to update the popper.js version independently

Does anyone have a concrete solution ?
I have the bug inside a table...

@pierre-H did you try bumping popper.js to 1.11.0?

Perhaps #1001 might help?

@martijnrusschen, with the caret dependencies, it can be bumped independently -- it only locks in the first non-zero number, and from what I can tell the recent react-popper dependencies on popper.js are also carets. Regardless, we should make that change =)

Ah yes, just upgrading it for my own sanity to get it removed from the yarn outdated list in that case :)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Was this page helpful?
0 / 5 - 0 ratings