React-datepicker: Replace `tether` with `popper` package for calendar popups

Created on 22 Jun 2017  路  9Comments  路  Source: Hacker0x01/react-datepicker

This is a follow up from the discussion at #899.

Since the project status for Tether is up in the air, Popper.js seems like a better alternative & even the maintainers of Tether recommended it.

Most helpful comment

Take a look at react-popper for a battle tested React integration with Popper.js

All 9 comments

@alex-shamshurin @martijnrusschen @rafeememon Would be great if you guy can assign this issue to me =)

I don't think we use assignments in this repo but you're free to start working on this!

Take a look at react-popper for a battle tested React integration with Popper.js

@FezVrasta Thanks for the heads up, will look at it over the weekend!

Waiting for PR to test it!

@alex-shamshurin @rafeememon Just a quick question, do you think we should use popper.js directly or just use react-popper? Cause I'm a bit skeptical about how 'battle tested' this wrapper module is when there's no form of testing implemented =/

Also, let's say we're using react-popper and there's some bug in popper.js or react-popper itself, won't we have to wait for the guys w/ the react-popper to fix the stuff before we can update our dependencies & ship the fix on our end?

I use react-popper in production and it works wonderfully.

I know there's an issue open to add tests, rather than create a new project consider add tests to the existing one maybe?

Also, react-popper doesn't lock you to a specific version,this means you can update Popper.js independently.

@FezVrasta Thanks for the quick reply! Didn't realize that you're also the creator of popper.js, I guess I shouldn't be worried about this issue then xD

@alex-shamshurin @rafeememon Popper.js uses a different way of specifying the behavior of the popups & there's some differences in functionality...

Do you guys intend to maintain the same API & all tether related props? (classPrefix, attachment, targetAttachment, targetOffset, renderElementTo, constraints)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

formigone picture formigone  路  3Comments

dhruvparmar372 picture dhruvparmar372  路  3Comments

sarav1234 picture sarav1234  路  3Comments

ahribori picture ahribori  路  3Comments

flaurida picture flaurida  路  3Comments