React-datepicker: React v15.0

[tkawachi]

React v15.0 was released.
http://facebook.github.io/react/blog/2016/04/07/react-v15.html

[martijnrusschen]

Will upgrade this weekend if no-one beats me.

[rafeememon]

Here are the things we need before we upgrade:

• [x] [react-tether](https://github.com/souporserious/react-tether/) needs an updated dependency
• [x] We need a fix for https://github.com/Pomax/react-onclickoutside/issues/79 EDIT: fixed in v4.8.0
• [x] [redbox-react](https://github.com/KeywordBrain/redbox-react) needs an updated dependency EDIT: removing the dependency
• [x] [react-tether](https://github.com/souporserious/react-tether/) needs to be able to accept DOM nodes for renderElementTo EDIT: inlining TetherComponent in this repo instead

[martijnrusschen]

Opened a PR for react-tether: https://github.com/souporserious/react-tether/pull/15

[joelzimmer]

Hey guys, when will this be merged with a new version?

[halloffame]

Looks like a new version of react-tether was released with the dependency change
v0.5.1
https://www.npmjs.com/package/react-tether

[pocketjoso]

Would be great to get this bumped!

[rafeememon]

Looks like redbox-react also needs an updated dependency. Also could ditch this dependency entirely; the console is good enough for error messages IMO

[joelzimmer]

We'd really appreciate a version bump since it would help us upgrade one of our projects to use React 15.

[halloffame]

I'm all for ditching dependencies if they are not really necessary.

[martijnrusschen]

Lets try to keep redbox-react in the stack is possible. It's a great tool when developing the examples site.

@halloffame It's just a devDependency. Doesn't hurt the component itself.

I'll try to make the dependency compatible with React 15.

[rafeememon]

It's just a devDependency. Doesn't hurt the component itself.

TBH I think this makes it even more silly that it's blocking the upgrade. :stuck_out_tongue: Let's hope that your PR gets merged soon.

[martijnrusschen]

Agree lets get rid of redbox-react for now :)

[rafeememon]

Unfortunately there's yet another issue -- the react-tether library now only accepts strings (i.e. query selectors) instead of objects (i.e. DOM elements) for the renderElementTo prop. This will need to be accounted for as well before we can upgrade.

Build with the error: https://travis-ci.org/Hacker0x01/react-datepicker/builds/123778821

[rafeememon]

renderElementTo fix: https://github.com/souporserious/react-tether/pull/19

[michaelzoidl]

Hey guys, is there some work-around to get the react-datepicker working?
In another project just removing react v0.14 from the peerDependencies in the package.json worked, seems like this works not for this project.

[rafeememon]

We can't remove react from peerDependencies and we need to support our API, so until the fix for react-tether is merged and released we can't upgrade to v15.

[peXed]

Hello! @rafeememon how is the status on this? React-tether is now up-to-date with their dependencies again or is still something missing?

[rafeememon]

@peXed, waiting for https://github.com/souporserious/react-tether/pull/19 to merge

[rafeememon]

Since there isn't any movement on the react-tether PR, I think we should probably inline the TetherComponent into this repo and make the changes we need. Hopefully I can take care of this tonight.

[orangecoding]

@rafeememon is there a plan when React 15 will finally be supported as I would love to use this within my project. Anything I can help with to speed things up?

[martijnrusschen]

We're almost there. #469 should remove the latest blocker.

[orangecoding]

k. If there's anything I can help with, just comment.

[rafeememon]

@martijnrusschen, I merged the final change in #451. I think it's time to cut a release :beers:

[martijnrusschen]

I'll do a release tomorrow :)
On vr 29 apr. 2016 at 22:06 Rafee Memon [email protected] wrote:

@martijnrusschen https://github.com/martijnrusschen, I merged the final
change in #451 https://github.com/Hacker0x01/react-datepicker/pull/451.
I think it's time to cut a release [image: :beers:]

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
https://github.com/Hacker0x01/react-datepicker/issues/444#issuecomment-215866419

[martijnrusschen]

Done: https://github.com/Hacker0x01/react-datepicker/releases/tag/v0.27.0

[orangecoding]

@martijnrusschen awesome mate. thanks!