React-custom-scrollbars: d.ts not updated

Created on 1 Mar 2017  路  5Comments  路  Source: malte-wessel/react-custom-scrollbars

The d.ts of the project is not updated.
The main problem is the inclusion of this line:

import React = __React;

When using @types/react there is no global variable named __React and so this file breaks the build.
The solution is kind of easy - omit the d.ts file from the project.
This way, whoever wants to use the d.ts will use @types/react-custom-scrollbars which don't use the global __React variable.

(In a way, inserting the d.ts was a breaking change for everyone who used @types/react).

Let me know what you think.

enhancement

Most helpful comment

All 5 comments

+1 the .d.ts file in project breaks usage.

I'm not quite familiar with TypeScript, would be cool if someone made a PR to fix this!

  1. remove the index.d.ts file,
  2. and delete
    "typings": "index.d.ts",
    section in package.json.

Fixed by #135

Was this page helpful?
0 / 5 - 0 ratings