React-color: BlockPicker: don't invoke onChangeComplete when typing an hex color in EditableInput

[ibc]

Currently, as far as I type #000 in the EditableInput within the BlockPicker, the onChangeComplete prop is called.

Well, actually I wanted to type #000FFF. Could onChangeComplete be called just when Enter is pressed or something like that?

[MattNot]

Same problem, only 3 chars... why?

[casesandberg]

I can indeed reproduce this here: https://codesandbox.io/s/0vo3zz6450. This is a bug.

[jakobsandberg]

@casesandberg what's the expected behaviour here?

[kinhbang89]

Hi I have been facing the same issue and I have noticed that when I typed valid hex color on the EditableInput, the library checker _color.isValidHex(hexCode)_ is wrong in onChange handler because the hexCode is {undefined: "#22194E"}.

[erkkaha]

Looks like the issue is here https://github.com/casesandberg/react-color/commit/aba3336489fb0c45d21a988903eb76c7f2ea640c#diff-4584130a5bc9a8717f47d3c842478b49R77
_this.props.label_ is undefined ie not _null_ . Can the check be for falsy values instead of strictly _null_?

[casesandberg]

Makes sense to me. Do you mind throwing up a PR with that fix?

Sent via Superhuman iOS ( https://sprh.mn/[email protected] )

On Thu, May 9 2019 at 12:15 PM, < [email protected] > wrote:

Looks like the issue is here aba3336 #diff-4584130a5bc9a8717f47d3c842478b49R77
(
https://github.com/casesandberg/react-color/commit/aba3336489fb0c45d21a988903eb76c7f2ea640c#diff-4584130a5bc9a8717f47d3c842478b49R77
)
this.props.label is undefined ie not null. Can the check be for falsy
values instead of strictly null ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (
https://github.com/casesandberg/react-color/issues/512#issuecomment-490861638
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/ABDLIJH3QQDT4DH7ZSKXSV3PUQBWXANCNFSM4E7O6X3Q
).

[juan0087]

I'm on the latest version 2.17.3 and the problem is still there. The hex code on the BlockPicker does not update/save.

[uzeuze]

@juan0087 I had the same issue. It is resolved after downgrading to version 2.14.1.

[erkkaha]

@casesandberg Would it be possible to get a new release to get this fixed?

[juan0087]

@uzeuze Thanks! I downgraded to 2.14.1 and it saves now, but when you type the hex value it takes the first 3 characters and closes popup.

[focux]

It seems that @erkkaha fix is in the last release but it didn't fix the issue. I'll be glad to fix it and open a PR if @casesandberg thinks it's okay.

[erkkaha]

@focux If you see https://github.com/casesandberg/react-color/compare/v2.17.3...master and https://github.com/casesandberg/react-color/pull/616 Fix has not been released yet. Downgrading is a way to fix this issue until new release is out.

[Amonaval]

@casesandberg Can we expect this issue to be resolved in the latest upcoming release ?

[lardissone]

Any updates on this? Bug is still present.