React-calendar-timeline: position: fixed on ancestor breaks drag and drop

[danielcruser]

Bug
dragging an item does not work if there is an ancestor with position: fixed

To Reproduce
CodeSandbox

Expected behavior
I expect to be able to trigger move/resize on the items. Instead there is no response.

Screenshots

Library Version
[email protected]

Desktop specs:

• OS: macOS
• Browser: Chrome
• Version 79

Additional context
If I change line 40 of utility/dom-helpers from
if (node === document.body) {
to
if (node === document.body || !node.offsetParent) {
the issue goes away. This makes sense given the MDN docs on HTMLElement.offsetParent

I've opened a pr, if there is a better way to go about fixing this I'd be happy to help.

[FridgeWalaby]

I ran into the same issue.

[Ilaiwi]

@FridgeWalaby @danielcruser I will release this today. @danielcruser Thank you for digging into this and solving the issue

[genlee025]

I am getting the same issue in the getSumScroll function in the dom-helpers file. Can we add the same check that is applied to getSumOffset to getSumScroll:
Error shown in console:

Error Traceback:

Old code with null node check in getSumOffset only:

Proposed new code with checks in both getSumScroll and getSumOffset