React-bootstrap-table2: Property condensed has no effect with bootstrap4

Created on 9 Oct 2018  路  6Comments  路  Source: react-bootstrap-table/react-bootstrap-table2

Setting condensed to true or false makes no difference when you use bootstrap4. The css class table-condensed was removed there. Instead you should use .table-sm. Additionally it was useful to add .form-control-sm on a condensed table to all .form-controls.

If you want, I can try to make a pull request.

enhancement good first issue

Most helpful comment

This issue is still not fixed in latest 3.3.0. Any solution?

image

No table-sm.

All 6 comments

@sedrubal ok, PR is welcome :)

@AllenFang @sedrubal

Additionally it was useful to add .form-control-sm on a condensed table to all .form-controls.

Implemented for bootstrap 3 and 4, will be included in the next PR :)

@AllenFang Yes, the condensed property was fixed, but didn't add .form-control-sm on condensed table forms which was the second suggestion:

Setting condensed to true or false makes no difference when you use bootstrap4. The css class table-condensed was removed there. Instead you should use .table-sm.

Additionally it was useful to add .form-control-sm on a condensed table to all .form-controls.

Nice, thanks. Sorry for not crating a pull request.
Unfortunately we switched back to bs 3 with our project...

This issue is still not fixed in latest 3.3.0. Any solution?

image

No table-sm.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dillobird picture dillobird  路  3Comments

prajapati-parth picture prajapati-parth  路  4Comments

primakashi picture primakashi  路  3Comments

kamarajuPrathi picture kamarajuPrathi  路  4Comments

SandeepKapalawai picture SandeepKapalawai  路  3Comments