React-bootstrap-table2: Drop Bootstrap 3

Created on 12 Oct 2017  路  8Comments  路  Source: react-bootstrap-table/react-bootstrap-table2

HI Allen,

I suggest that your new version of react-bootstrap-table be pure Flexbox, which means supporting only Bootstrap 4 and not Bootstrap 3.

Bootstrap 4 is pure Flexbox.

It's a good idea because supporting two radically different layout engines will end up being a nightmare for you.

Better to leave react-bootstrap-table version 1 as Bootstrap 3, and make react-bootstrap-table version 2 support only Bootstrap 4.

Refer here:

https://github.com/twbs/bootstrap/pull/21389
https://github.com/twbs/bootstrap/issues/19901

Thanks

good first issue

Most helpful comment

Actually there are tables in Bootstrap 4: https://getbootstrap.com/docs/4.0/content/tables/
And i bet there are quite a few people who would really appreciate if react-bootstrap-table2 could also be used with bootstrap3.

All 8 comments

It's a good point. but do you suggest to use flexbox instead of table HTML tag?

The future is Flexbox. Yes I'd suggest Bootstrap 4 only, and no table tag at all, just Flexbox.

It will hurt for while until you gain expertise with it, but it's a much better path to invest in for the future.

Or probably we can have a branch alongside and see if flexbox is worth.

@prajapati-parth Flexbox is the future, tables the past. Twitter Bootstrap has committed fully to Flexbox.

sure, we need some experiment to prove flexbox can be implement a table, for example: control the width, vertical/horizontal scroll ...etc

Actually there are tables in Bootstrap 4: https://getbootstrap.com/docs/4.0/content/tables/
And i bet there are quite a few people who would really appreciate if react-bootstrap-table2 could also be used with bootstrap3.

@cbergmiller react-bootstrap-table2 will compatible with bootstrap3 and 4, actually, react-bootstrap-table did it already.

Flexbox is good for page layouts but this is about data tables and I think it should still use regular table tags for that, it's more semantically correct.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

eylonronen picture eylonronen  路  3Comments

ethannkschneider picture ethannkschneider  路  3Comments

kamarajuPrathi picture kamarajuPrathi  路  4Comments

harishkumarreddy12 picture harishkumarreddy12  路  3Comments

prajapati-parth picture prajapati-parth  路  4Comments