React-big-calendar: onSelectSlot does not trigger if you drag from 9pm to the end of the day or any other combination

Created on 14 Mar 2019  路  7Comments  路  Source: jquense/react-big-calendar

Do you want to request a _feature_ or report a _bug_?

bug

What's the current behavior?

When dragging to create a slot event that includes the last cell of the day it does not trigger the onSelectSlot

https://codesandbox.io/s/xjrw3rqm14
http://recordit.co/jIsEIC1MRj

What's the expected behavior?

The onSelectSlot event should fire when the last slot of the day is included in dragging to create the event. This worked in version 0.20.2 but is broken in 0.20.3. We cannot downgrade to 20.2 as that will break the current time indicator and we prefer not to fork this to make it work by reapplying that fix.

If you change the version in the code sandbox you will see the issue.

All 7 comments

Seems that it was caused by this change:
https://github.com/intljusticemission/react-big-calendar/commit/aa8f08b35b94fec631b9cbe5555c28e3cce0563e#diff-230750937c0dc3204163caf44f0e8f55L277

@bs85 as a person who worked on this piece of logic, do you have any ideas how to fix selecting the last timeslot in the best way?

What solutions I see in this case:

  1. Undo this particular change
    Screen Shot 2019-03-17 at 14 19 26

  2. Make end slot to be selectable when mouse is over it (no need to move mouse bellow the slot)

screenshot-localhost-3000-2019 03 17-14-36-24

  1. ... any suggestions?

UPD. @jquense maybe we could hear your opinion, which UX is better?

Hey guys! I'm having the same issue. Any progress?

@dmitrykrylov I think the second option is a good way to go. Can you make a PR to update?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Any progress on this issue ?

_(This is a desperate attempt to keep this issue out of the bot's hands)_

I just added a pull request fixing this

Hi guys, I have met the same issue.
Any updates on this?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

nirchernia picture nirchernia  路  3Comments

ZacharyLangley picture ZacharyLangley  路  3Comments

KatiaPosPago picture KatiaPosPago  路  3Comments

Beyazatli picture Beyazatli  路  3Comments

bionicvapourboy picture bionicvapourboy  路  3Comments