React-beautiful-dnd: Trim some fat! 🥗

Created on 27 May 2018  Â·  12Comments  Â·  Source: atlassian/react-beautiful-dnd

There are some simple things we can do as a part of our build to hopefully drop some significant KB weight.

  • babel-plugin-dev-expression: remove all of our invariant message from production builds. Related: move all console.error expressions and move to invariant for consistent error handling (doing as a part of #493)
  • prepack try to reduce some functions into their static results
  • investigate our uglify options and see if there are any other approaches we can take advantage of
engineering health 🛠

Most helpful comment

Actually, I have created a new branch dev which now has the latest. Can you please start that @TrySound ?

All 12 comments

I could take a look after major state refactor merge

Do we have any components which can be unused in some cases?

No 😊
On Sun, 27 May 2018 at 10:45 pm, Bogdan Chadkin notifications@github.com
wrote:

Do we have any components which can be unused in some cases?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/atlassian/react-beautiful-dnd/issues/525#issuecomment-392328532,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACFN7Wzw5q_DpVwuPxFXR_9BDNnjNkmNks5t2qABgaJpZM4UPO31
.

Hey @TrySound, I almost have a stable branch that this work can start on. Are you keen to pick it up?

No pressure though, I am okay to do it too. I just wanted to give you the opportunity if you would like too!

I'll take a look

okay sure, the branch is the ~major-state-refactor~ dev

it is green now, and should stay mostly intact

it also has a lot of bumped dependencies

Actually, I have created a new branch dev which now has the latest. Can you please start that @TrySound ?

@TrySound I have bumped the rollup dependencies and it looks like the uglify plugin and your size plugin are no longer working. Feel free to roll them back to a stable version.

Shipped in version 9

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Tsabary picture Tsabary  Â·  3Comments

alexreardon picture alexreardon  Â·  3Comments

h182032 picture h182032  Â·  3Comments

gitleet picture gitleet  Â·  3Comments

heymartinadams picture heymartinadams  Â·  3Comments