React-autosuggest: Warning about `componentWillReceiveProps` in React's Strict Mode

Created on 16 Mar 2019  路  7Comments  路  Source: moroshko/react-autosuggest

React's Strict Mode warns about "Unsafe lifecycle methods were found within a strict-mode tree".

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead.

https://github.com/moroshko/react-autosuggest/blob/d626cef720df0ed5a4c7df4d539836b86bda6afa/src/Autosuggest.js#L124-L143

help wanted
Source
picture ulrichb
👍46 👀2

Most helpful comment

Any update on this @moroshko ?

picture Kove11 on 13 Aug 2019
👍25

All 7 comments

Now with React 16.9 it's even a non-strict mode warning ...

ulrichb picture ulrichb on 9 Aug 2019
👍24

Any update on this @moroshko ?

Kove11 picture Kove11 on 13 Aug 2019
👍25

Still very relevant, looking forward to updates

ghost picture ghost on 30 Sep 2019
👍13

Here's a PR that should take care of it: https://github.com/moroshko/react-autosuggest/pull/681

rlueder picture rlueder on 23 Oct 2019

Fixed in #681

aberezkin picture aberezkin on 17 Mar 2020

@aberezkin this should not have been closed. It resolves https://github.com/moroshko/react-autosuggest/issues/670, but not this one. A warning is still shown in React's strictmode:

Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code.
wzijden picture wzijden on 9 Apr 2020

Can someone work on this?

aberezkin picture aberezkin on 11 Apr 2020
👀1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Razinsky picture Razinsky  路  3Comments
cristian-sima picture cristian-sima  路  3Comments
samuelg0rd0n picture samuelg0rd0n  路  3Comments
luke-unifymonitor picture luke-unifymonitor  路  3Comments
ashwintastic picture ashwintastic  路  3Comments