React-apollo: Convert React.PropTypes to PropTypes provided by prop-types package

Created on 13 Apr 2017  路  4Comments  路  Source: apollographql/react-apollo

Hi there,

Just following your contributing guidelines. I'm able to submit a PR for this if you decide that's okay for me to do.

I'm sure you're all aware that React 15.5 deprecates React.PropTypes and moves it to its own module. Would this be something you are all okay with me doing in a PR?

Not a dire issue by any means, but it is somewhat annoying to see the console.error messages in my CI pipeline.

Thanks so much! Also, thanks for all your work on the Apollo project in general. 馃憤 馃憤

Most helpful comment

@helfer Great! Thanks for the hospitality 馃槃

It's quittin' time here in my neck of the woods, but I should be able to knock this out tomorrow sometime.

(If anybody else happens to be reading this and feels like beating me to it, by all means, go right ahead!)

All 4 comments

@dsifford if you end up doing it, FYI there is a codemod for it in here: https://github.com/reactjs/react-codemod#react-proptypes-to-prop-types,

@alfonsoperez Was not aware of that. Thanks, that'll definitely be helpful!

Hi @dsifford. That would definitely be a great PR that I would be extremely happy to merge 馃槂

Also, hi @alfonsoperez, great to see you here! :wave:

@helfer Great! Thanks for the hospitality 馃槃

It's quittin' time here in my neck of the woods, but I should be able to knock this out tomorrow sometime.

(If anybody else happens to be reading this and feels like beating me to it, by all means, go right ahead!)

Was this page helpful?
0 / 5 - 0 ratings