React-apollo: Variables don't mutate after update

[gauravtiwari]

Hey folks, So, looks like the variables are not reactive, meaning they don't update if they are mutated. For ex, I have this scenario, initially I have set variables like so, variables: { start: 0 } and later when user scrolls to the bottom of the page, I have updated the variables to this in the updateQuery method, variables: { start: this.props.data.variables.start + 20 }. Now, here is the timeline showing the state of the variables object,

It seems, it changes the first time, but again reverses to the initial variables object. Is it the desired behaviour? I think it should update with the components state.

[jbaxleyiii]

@gauravtiwari thanks for reporting this! I think it should be fixed with https://github.com/apollostack/react-apollo/pull/139

[gauravtiwari]

@jbaxleyiii Cool! thanks for looking into it 🍰

[jbaxleyiii]

@gauravtiwari this is released in 0.4.4. Let me know if it doesn't solve the problem!

[gauravtiwari]

@jbaxleyiii Looks like the problem still persists - same as the initial issue. The variables mutates first time and the comes back to it's initial value.

[jbaxleyiii]

@gauravtiwari oh no! I'll keep looking

[jbaxleyiii]

@gauravtiwari I've been able to reproduce and have pushed a failing test. You can track progress here: https://github.com/apollostack/react-apollo/pull/150

Thanks for the report!

[jbaxleyiii]

@gauravtiwari try 0.4.6

[gauravtiwari]

Awesome it works @jbaxleyiii. Have some 🍰