React-apollo: mapStateToProps params

Created on 19 Apr 2016  路  7Comments  路  Source: apollographql/react-apollo

It looks like mapStateToProps currently gets called with just the redux state. The docs show that it gets called with an object containing ownProps and state. Is it intended to contain ownProps as well? Or should we update the docs? cc @jbaxleyiii

bug
Source
picture johnthepink

All 7 comments

@johnthepink it should have ownProps. I thought I had a test in place for that?

jbaxleyiii picture jbaxleyiii on 19 Apr 2016

I had a few issues with various arguments as well. I don't think our tests totally cover the different lifecycle events with changes coming from props, redux, etc.

stubailo picture stubailo on 19 Apr 2016

@stubailo the tests are pretty minimal right now. @johnthepink would you be up to taking that for me today and tomorrow? Trying to be better about actually being on vacation ;)

jbaxleyiii picture jbaxleyiii on 19 Apr 2016

I managed to build an example app on top of it, so I'm happy! No rush on making these improvements, I think - vacation away!

stubailo picture stubailo on 19 Apr 2016
❤1

@stubailo @johnthepink is triumphantly moving our stavj to Apollo now so he may need some changes.

I'm really happy it's all decent ly coming together though!

jbaxleyiii picture jbaxleyiii on 19 Apr 2016

Yep! I'll jump in on fixing some stuff here soon. Found a couple other things.

johnthepink picture johnthepink on 19 Apr 2016

Fixed with #51

jbaxleyiii picture jbaxleyiii on 12 May 2016
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

notadamking picture notadamking  路  3Comments
johhansantana picture johhansantana  路  3Comments
KenilDomadia picture KenilDomadia  路  3Comments
voodooattack picture voodooattack  路  3Comments
bdouram picture bdouram  路  3Comments