React-admin: [RFC] Deprecate DisabledInput

Created on 13 Aug 2019  路  6Comments  路  Source: marmelab/react-admin

Following the review from @Kmaschta in #3515, we think the DisabledInput should be deprecated/removed.

  1. We can make almost any of the existing inputs disabled by setting either their disabled or readonly prop.

  2. We are binding a TextInput to the record value but are just not passing the event handlers. This results in an unresponsive text input, which is weird and probably confusing for people using screen readers as nothing indicates this input is readonly/disabled

enhancement

Most helpful comment

@ouonet You've read the wrong documentation. react-admin.com is not owned by the core team, and contains outdated documentation. The correct documentation, hosted at https://marmelab.com/react-admin/Tutorial.html, does not contain <DisabledInput> or <LongTextInput>. Please update your bookmarks.

All 6 comments

I agree. We should even remove it completely from 3.0 instead of deprecating it.

Do you mean we should remove all other deprecated components (LongTextInput for example)?

Fixed by #3549

@djhi @fzaninotto Does the LongTextInput needs to be removed? Should I work on it?

in https://react-admin.com/docs/en/tutorial.html, the example still use DisabledInput and LongTextInput . that causes confusion for beginner.

@ouonet You've read the wrong documentation. react-admin.com is not owned by the core team, and contains outdated documentation. The correct documentation, hosted at https://marmelab.com/react-admin/Tutorial.html, does not contain <DisabledInput> or <LongTextInput>. Please update your bookmarks.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kdabir picture kdabir  路  3Comments

nicgirault picture nicgirault  路  3Comments

kikill95 picture kikill95  路  3Comments

mbj36 picture mbj36  路  3Comments

samanmohamadi picture samanmohamadi  路  3Comments