React-admin: ReferenceField always display

[nacimgoura]

Hello,
thanks you for your project.
I think there is a bug with ReferenceField.
When I use ReferenceField and the source is null, the loading appears but remains indefinitely. I have the impression that the field does not check before if the source is not null.

I was able to correct this by doing it like that but I think there must be a better solution:

const ConditionalReferenceField = ({ record, ...rest }) =>
  record && record[rest.source] ? (
    <ReferenceField {...rest}>
      <TextField source="name" />
    </ReferenceField>
  ) : null;

• React-admin version: 2.3.3
• Last version that did not exhibit the issue (if applicable): no applicable
• React version: 16.5.2
• Browser: Chrome
• Stack trace (in case of a JS error): no

[TomJannes]

I think you can use the allowEmpty={true} attribute on the ReferenceField

[nacimgoura]

This does not correct the problem. What I want to do is display the reference when the source exists otherwise do not display anything (no loading when there is nothing).

[djhi]

@TomJannes is correct, that's what allowEmpty does on a ReferenceField

[nacimgoura]

I tried with allowEmpty={true} and allowEmpty={false}, but I still have the loading bar although the value is null.

Finally it works, I had to test it badly. Thank you very much! I close this issue.

[djhi]

Why did you close it?

[nacimgoura]

I edited my issue. Finally it works with allowEmpty={true}

[nacimgoura]

I'm reopening the subject, a bug does exist.

When a reference data exists the loading bar is replaced by the data but when it does not find anything the loading bar remains all the time. I don't think that's the way it should be.

Here, on the first line it does not find any data (infinite loading bar). on the second line, existing data and deleting the loading bar.
Ideally, the loading bar should disappear after a certain period of time without finding any data.

allowEmpty={true} just allows you not to display a loading bar.

[fzaninotto]

Let me reiterate: if a reference data does not exist but you don't allow empty, then your data has a referential integrity problem. React-admin assumes you respect referential integrity, and cannot handle cases when it's not the case...

Closing the issue as won't fix. Feel free to reopen if you disagree.

[fzaninotto]

and by the way, this is probably a duplicate of #854

[fzaninotto]

Refixed in #3550