React-ace: Diff tool does not highlight lines

Created on 31 Oct 2018  路  7Comments  路  Source: securingsincity/react-ace

Diff tool does not highlight lines (version 6.2.0)

I noticed the codeMarker styles are not available and it marks the wrong lines.

<DiffEditor
            value={this.state.value}
            height="1000px"
            width="1000px"
            mode={this.state.mode}
            onChange={this.onChange}
          />

issue

awaiting response

Most helpful comment

figure out, highlight style need import manually
.codeMarker { background: #fff677; position: absolute; z-index: 20; }

All 7 comments

@securingsincity ?

same issue

figure out, highlight style need import manually
.codeMarker { background: #fff677; position: absolute; z-index: 20; }

@dancancer could you make a pull request? And @securingsincity could you merge it and release new version?

Yeah. I am also facing the same issue

I can add this but I'm not sure how we would want to import styles. Currently this library doesn't export any styles. Do people have thoughts on how to best do this? or does it make more sense to add this as a requirement to using the diff library?

I also got hung up on this issue. I've added a sandbox that imports the missing styles explicitly:

https://codesandbox.io/s/825n0z60ol?fontsize=14

Was this page helpful?
0 / 5 - 0 ratings

Related issues

anderoonies picture anderoonies  路  5Comments

huangjiatian picture huangjiatian  路  7Comments

viridia picture viridia  路  4Comments

dmavrin picture dmavrin  路  3Comments

burks10 picture burks10  路  3Comments