Razorlight: new RawString(string.empty) crashes

Created on 28 Mar 2018 · 10Comments · Source: toddams/RazorLight

new RawString(string.Empty) is crashing. It should not throw an argument null exception.

Source

ada3m0n666

👍4

Most helpful comment

I disagree, it should mimic the Html.Raw Razor directive, which handles empty/null content. If the value is empty or null it returns HtmlString.Empty. A similar approach should be taken here.

nloding on 2 May 2018

👍2

All 10 comments

Seems like the check here could be ammended to check for null rather than NullOrEmpty.

csr-nick on 9 Apr 2018

I disagree, it should mimic the Html.Raw Razor directive, which handles empty/null content. If the value is empty or null it returns HtmlString.Empty. A similar approach should be taken here.

nloding on 2 May 2018

👍2

I agree with @nloding. Coming from RazorEngine, a whole bunch of our tests around are templates are broken because we didn't specify a value for every single property.

mscrivo on 4 May 2018

@mscrivo you beat me to it - I was going to submit a PR this weekend :) Thanks for doing that, hopefully @toddams can get it pulled in!

nloding on 4 May 2018

@nloding no problem .. am actively working with it right now and it's blocking me, so I don't have much choice :) I've published a package with the changes here: https://www.nuget.org/packages/RazorLight.Unofficial .. will likely get rid of that at some point if @toddams merges the changes, or has a better way of fixing these issues.

mscrivo on 4 May 2018

👍1

@toddams what is the logic with throwing an exception when the argument is null, which is break from how the Razor engine handles Html.Raw?

nloding on 4 Jun 2018

Why is this issue closed? The latest package(2.0.0-beta1) doesn't resolve this problem.