Ray: Task Cancellation is broken for queued tasks

Created on 17 Nov 2020  路  5Comments  路  Source: ray-project/ray

What is the problem?

  • After #11051 , tasks that are not yet executing may not be cancellable.
  • Tasks cancellation is implemented for tasks that are pending a lease, or are currently running on the worker

Change needed

  • Basically HandleCancelTask should also ask direct_task_receiver_ to cancel a task (delete it from queue)

  • [ ] I have verified my script runs in a clean environment and reproduces the issue.

  • [ ] I have verified the issue also occurs with the latest wheels.
P2 bug

All 5 comments

@gabrieleoliaro Hey I saw that you implemented queuing for non-actor tasks (which is super exciting!) and I was wondering if you could extend task cancellation to cancel tasks that are queued at the remote backend worker?

@gabrieleoliaro Hey I saw that you implemented queuing for non-actor tasks (which is super exciting!) and I was wondering if you could extend task cancellation to cancel tasks that are queued at the remote backend worker?

Thanks for bringing this up, @ijrsvt ! I'll look into this.

@gabrieleoliaro Awesome! Please let me know if you have any questions!

@ijrsvt I just opened a PR to address this issue! I can't assign people to review my code, so feel free to either assign yourself, or somebody else. Thanks!!

@gabrieleoliaro Thanks for doing that so quickly!

Was this page helpful?
0 / 5 - 0 ratings