Rawtherapee: Roadmap for 5.8

[Beep6581]

ETA 14 December 2019.

[snappyapple632]

It seems like #1678 is nearing testing stages, Sounds like a pretty revolutionary upgrade. Would it be something to consider?

[heckflosse]

@snappyapple632 #1678 will require a lot of work after the functionality is tested, because using OpenCL requires additional dependencies and we also have to handle cases where the data is too much to fit in the RAM of the graphics card and so on. I don't even know the code atm. So, definitely not for 5.8.
But as we need more speed especially for Capture Sharpening and it's a perfect candidate to speed this up, I will test it, as soon as it's available.

[snappyapple632]

Understandable, but I will continue to anticipate its integration.

[SilvioGrosso]

The feature planned, by Hombre57, "Adding GUIs to the favorites", would be cool as well:
https://github.com/Beep6581/RawTherapee/issues/5256

However, having the "Local editing branch" released (https://github.com/Beep6581/RawTherapee/tree/newlocallab) would be even massively useful :-)
Just joking though, since I am not a developer and I don't know how difficult would be to have these new 2 features included in the next 5.8 release...

[SilvioGrosso]

Needless to say, I suppose the "Spot remove branch", by Hombre57, will be included as well (I suppose this is far more certain...)?

[Beep6581]

We will include what's ready for inclusion when the time comes.

[SilvioGrosso]

Hello @Beep6581

We will include what's ready for inclusion when the time comes.

Sure!
You are 100% right and trust me: I don't want to press anyone since I am fully aware you are working on Rawtherapee in your very limited amount of time, for free...

As regards the Local editing branch, IMHO, it is such an important improvement that it might merit a big number release for Rawtherapee (6.0 etc).
I was thinking about the 5.8 release because it might allow to test it more in depth. Currently, it looks like it receives little testing since you are forced to test its specific branch and not every "casual" user is willing to do so...
In addition, since the "Spot removal branch", from what I have gathered, is not fully back compatible (as the pp3 stuff is concerned) both branch additions might be coupled together in an upcoming release warning every user that they might pay great attention while working with them since weird stuff can occur with their pictures :-)

[Hombre57]

@SilvioGrosso I'll do my best to finish the Spot Removal tool for 5.8.

For Local Editing, this is something that everybody eagerly wants, but a Casus Belli for devs. It's such a big improvement with different possible implementation, that in the end, users will have to chose between different fork.

[Beep6581]

5.8 will not be released until all documentation is written (all documentation issues closed), including those for past milestones. It can be written here in GitHub, then I'll rewrite it for RawPedia.

[SERGIOTOUS]

Hi, Is Dec. 14th still considered as ETA for v5.8? thanks

[snappyapple632]

Usually the ETAs are ballpark figures and aren't assumed to be strict.

[Beep6581]

Dec 14 seems unlikely.

[rfranke]

1678 sounds cool -- in particular as omp isn't without issues either, e.g. with clang. Maybe make opencl optional and keep the current processing as fallback to minimise the risk of breaking RT?

[rfranke]

Mac version:
I find a solution to #5596 crucial for the 5.8 release to get rid of frequent crashes of RT under macOS.
Moreover, #5607 would be nice to have to make scrolling usable in the thumbs browser.

[Beep6581]

Unless anyone objects, I will be merging these tonight:

5607 Fix scrolling in thumb browser under macOS

5596 Frequent crashes of file browser under macOS

Then, after 5 days of testing, v5.8 will be tagged on February 1.

[Beep6581]

@Benitoite @rfranke if there are any more changes needed for macOS, please try to make them before Saturday.

Is there any chance that v5.8 will work in macOS 10.15 Catalina?

[Benitoite]

@Beep6581 that is definitely the goal... ATM I am chasing (packaging-related) errors, as Catalina enforces more application integrity by default than previous macOSes.

[rfranke]

PR #5625 shall fix issue #5622 for macOS (missing lens data). It doesn't seem to make a difference under Linux as the cmake option LENSFUNDBDIR is not used. Didn't investigate Windows though.

The removed lines in CMakeLists.txt had been added as part of 008f280e2918cce406c270161f825c96b7421eba "lensfun: added possibility to use a private copy of the LF database".
The second prepend of DATADIR was added with be39ef32603bb5b9a280413c64b182c6c2519a33 "lensfun: added possibility to use a private copy of the LF database".

[Beep6581]

Branch release-5.8 ready.

The RawTherapee 5.8 release is now pending only on the macOS build issues. Once macOS builds work, we can merge and release.

[Beep6581]

RawTherapee 5.8 is released.

[Benitoite]

My work on a macos 10.9 build is just pending a rebuild of meson Glib. (and the gtk stuff that follows glib)

[Beep6581]

@Benitoite @rfranke @Krijger you can let me know here when a tested build for macOS is ready.

[Benitoite]

Some nominal reports have come in:

• macos 10.13
  
  
  
  • zurdo
  
  
• macos 10.__
  
  
  
  • 120photo
  
  
• macOS 10.11
  
  
  
  • carlos1960
  
  

https://kd6kxr.keybase.pub/RawTherapee_OSX_10.9_64_5.8.zip
This is built to run on macOS versions 10.9,10,11,12,13,14,15+

Version: 5.8
Branch: 5.8
Commit: 9a9e0acbf
Commit date: 2020-02-04
Compiler: clang 11.0.0.11000033
Processor: generic x86
System: Apple
Bit depth: 64 bits
Gtkmm: V3.24.2
Lensfun: V0.3.95.0
Build type: release
Build flags: -Wno-deprecated-register -Wno-unused-command-line-argument -std=c++11 -std=c++11 -mtune=generic -Werror=unused-label -Werror=delete-incomplete -mmacosx-version-min=10.9 -flto -Wall -Wuninitialized -Wcast-qual -Wno-deprecated-declarations -Wno-unused-result -Xpreprocessor -fopenmp /opt/local/lib/libomp.dylib -I/opt/local/include -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
Link flags:  -mtune=generic -headerpad_max_install_names -flto
OpenMP support: ON
MMAP support: ON

A known issue in 5.8 (also before 5.7) for mac is that sub-windows like Preferences pop up over the full screen while in fullscreen mode. #5579

Some security permissions may need to be set for some users to access external disk volumes... #5635

macOS 10.15 Catalina users will want to know in order to access files in locations other than ~ and ~/Pictures:

• You must physically add /bin/sh to Full Disk Access under Privacy in the Security & Privacy Control Panel.

• You may need to navigate to the /bin folder using Go > Go to Folder... (Command-Shift-G)
  You can drag sh onto the panel.
  

To install, unzip, open the dmg, and drag the RawTherapee icon onto the provided Applications folder alias.

A repackaged 5.7 was also generated: https://kd6kxr.keybase.pub/RawTherapee_OSX_10.9_64_5.7.zip

[Beep6581]

@Benitoite great, busy uploading it with instructions from here:
https://discuss.pixls.us/t/rawtherapee-macos-build-needs-urgent-testing/16176/31?u=morgan_hardwood

Note:

1. There is no more need to package AboutThisBuild.txt alongside the build - it should still be _within_ the build, so inside the DMG in this case, but you no longer need to zip it with the DMG.
2. There is a new filename scheme we're sticking with, also (to be) used by HDRMerge, see here:
   https://github.com/Beep6581/RawTherapee/issues/5551
   So in the macOS case, for the 5.8 release the filename should be:
   RawTherapee_5.8.dmg
   and for a build of the dev branch, it should be:
   RawTherapee_dev_5.8-5-g9bcebf54d_20200206.dmg