Rawtherapee: Roadmap for 5.6

[Beep6581]

Feature-freeze and release candidates mid March 2019.
Release date: 2019-04-01.

[Thanatomanic]

We currently have 40 open issues because I recently had been tagging some 'important' stuff to work on. However, this may be a little overzealous. Maybe we need a v6.0 milestone to push some longer-term projects into?

[heckflosse]

@Beep6581

Release date: 2019-04-01

Veto! either 2019-04-02 or 2019-03-31 ;-)

[Beep6581]

@Thanatomanic don't worry about that, we will kick issues to further milestones closer to the release date out of necessity, not much point doing that prophylactically.

@heckflosse 2019-03-31 is a Sunday, so :+1:

[Beep6581]

I think we're all set for a release candidate. I'll start the work and tag rc1 this weekend, if no objections.

[Beep6581]

Branch ready: https://github.com/Beep6581/RawTherapee/tree/release-5.6

I will tag 5.6-rc1 tonight if no objections.

[Floessie]

Builds and runs fine on Debian 10 amd64/i386/ppc. :+1:

[agriggio]

I have a fix for dehaze that I forgot to backport to dev, but maybe it's too late?

[Beep6581]

@agriggio what's the fix?

[heckflosse]

@agriggio Alberto, it's (almost) never too late

[heckflosse]

Builds and runs fine on Win7/64

[Beep6581]

As my spiritual guru Sylvester Stallone said, "It's not over till it's over".

[agriggio]

it's a fix to avoid mismatch between preview and output:

https://discuss.pixls.us/t/haze-removal-wrong-colors-in-export/11969/36?u=agriggio

[Floessie]

@Beep6581

As my spiritual guru Sylvester Stallone said, "It's not over till it's over".

Spiritual guru... :joy: Now I can't get that catchy tune by Lenny Kravitz out of my head... :notes: :dizzy_face:

[Beep6581]

@agriggio as no one has complained about this in RT yet, and as we haven't seen the patch and I don't want to commit last-minute untested patches to a release candidate (testing should be allowed to take days at least, and usually involves code tweaks), and as it's already 9PM, I'm going to go ahead and tag the release, and we can include the fix in 5.7, "out soon".

[Beep6581]

RawTherapee 5.6-rc1 is released:
https://github.com/Beep6581/RawTherapee/blob/5.6-rc1/RELEASE_NOTES.txt#L31
https://rawtherapee.com/blog/rawtherapee-5.6-release-candidate-1

If builds show up quickly and if no issues arise, 5.6-final will be released around this weekend.

[agriggio]

fair enough. I've seen discrepancies myself fwiw, but I'd need to dig out the examples. anyway I'm sick so I won't be able to commit today

[Floessie]

5.6-rc1 builds and runs fine on an updated FreeBSD 12, too.

[gaaned92]

W10: builds and runs fine
https://keybase.pub/gaaned92/RTW64NightlyBuilds/RawTherapee_release-5.6_5.6-rc1-1-gf237a9a0b_WinVista_64_190411.zip uploaded

[Beep6581]

I'm waiting for more information regarding the scaling issue before deciding how to proceed.

[Beep6581]

I will tag 5.6-rc2 tomorrow. @Benitoite @gaaned92 would be great if you were available in the evening (Europe-time) to make builds, then there's a chance we could have 5.6-final for Easter.

[Beep6581]

5.6-rc2 is tagged, @Benitoite @gaaned92 please link to builds either here or preferably directly in the forum https://discuss.pixls.us/t/test-rawtherapee-5-6-rc2/12165

[gaaned92]

Done:
https://keybase.pub/gaaned92/RTW64NightlyBuilds/RawTherapee_releases_5.6-rc2_WinVista_64_190417.zip
uploaded
link provided also on pixls

[Beep6581]

@gaaned92 seems there's an issue with missing "+" icons in the tree browser.

[gaaned92]

@Beep6581
What I see missing are the arrows (triangle shape) in front of folders.
Surely a bad MSY2 update of adwaita icons theme.
I am looking at that.
edit:should be corrected now

In mingw64shareiconsAdwaitascalableactions folder, all the pan*.svg icons are missing in the last update. I just copied them back.

[Beep6581]

I will tag 5.6 this evening.

[Benitoite]

I will tag 5.6 this evening.

Here is a build for MacOS 10.9,10,11,12,13,14+:

https://kd6kxr.keybase.pub/RawTherapee_OSX_10.9_64_5.6.zip

Version: 5.6
Branch: 5.6
Commit: 5a4ed7317
Commit date: 2019-04-20
Compiler: clang 10.0.1.10010046
Processor: generic x86
System: Apple
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.95.0
Build type: release
Build flags: -std=c++11 -std=c++11 -mtune=generic -Werror=unused-label -mmacosx-version-min=10.9 -flto -Wall -Wuninitialized -Wno-deprecated-declarations -Wno-unused-result -Xpreprocessor -fopenmp /opt/local/lib/libiomp5.dylib -I/opt/local/include -Werror=unknown-pragmas -O3 -DNDEBUG -ftree-vectorize
Link flags:  -mtune=generic -headerpad_max_install_names -flto
OpenMP support: ON
MMAP support: ON

lensfun timestamp.txt: 1555785085

Build by Richard Barber💈

[Beep6581]

That was fast :D

[Benitoite]

A command alias calls the build script and copies the final zip to the keybase folder. :P

[Beep6581]

A magician never reveals his secrets ;)

[Benitoite]

alias update56='sudo sh ~/macgenerateRT56 && cp ~/repo-rt/build/*zip /keybase/public/kd6kxr && echo "-update completed-"'

$ cat ~/macgenerateRT56
cd ~/repo-rt/build && sudo rm -r * &&  git pull && git checkout 5.6 && cmake -DCMAKE_BUILD_TYPE="release"       -DPROC_TARGET_NUMBER="1" -DPROC_LABEL="generic processor"       -DCACHE_NAME_SUFFIX=""       -DCMAKE_C_COMPILER="clang"       -DCMAKE_CXX_COMPILER="clang++"       -DWITH_LTO="ON"    -DCMAKE_OSX_SYSROOT="/" -DCMAKE_OSX_DEPLOYMENT_TARGET="10.9"  -DLENSFUNDBDIR="./share/lensfun" -DCODESIGNID:STRING="Developer ID Application: Richard Barber (5SJ86G6Q2R)" -DCMAKE_CXX_FLAGS="-std=c++11" -DOpenMP_C_FLAGS=-fopenmp=lomp -DOpenMP_CXX_FLAGS=-fopenmp=lomp -DOpenMP_C_LIB_NAMES="libiomp5" -DOpenMP_CXX_LIB_NAMES="libiomp5" -DOpenMP_libiomp5_LIBRARY="/opt/local/lib/libiomp5.dylib" -DOpenMP_CXX_FLAGS="-Xpreprocessor -fopenmp /opt/local/lib/libiomp5.dylib -I/opt/local/include" -DOpenMP_CXX_LIB_NAMES="libiomp5" -DOpenMP_omp_LIBRARY=/opt/local/lib/libiomp5.dylib -DOpenMP_C_FLAGS="-Xpreprocessor -fopenmp /opt/local/lib/libiomp5.dylib -I/opt/local/include"   -DCMAKE_VERBOSE_MAKEFILE:BOOL=ON   .. && make -j8 install && sudo make macosx_bundle

$ update56

[...]

-update completed-
$

[gaaned92]

https://keybase.pub/gaaned92/RTW64NightlyBuilds/RawTherapee_5.6_WinVista_64.zip
uploaded

Version: 5.6
Branch: 5.6
Commit: 5a4ed7317
Commit date: 2019-04-20
Compiler: gcc 8.3.0
Processor: generic x86
System: Windows
Bit depth: 64 bits
Gtkmm: V3.24.1
Lensfun: V0.3.2.0
Build type: release
Build flags:  -m64 -mwin32 -msse2 -mfpmath=sse -mthreads -Wno-aggressive-loop-optimizations -Wno-parentheses -std=c++11 -mtune=generic -Werror=unused-label -Wall -Wuninitialized -Wno-deprecated-declarations -Wno-unused-result -fopenmp -Werror=unknown-pragmas  -DNDEBUG  -O3 -ftree-vectorize
Link flags: -m64  -mthreads  -static-libgcc   -mtune=generic  -s  -O3  -fno-use-linker-plugin
OpenMP support: ON
MMAP support: ON

Last lensfun update from 16/04/19.
Oh! I am the last to build 5.6 :worried:

[Beep6581]

Thank you, all builds are now live.

I will work on the 5.5 and 5.6 milestones issues over the course of the week.