Rawtherapee: Info: GTK+ 3.22.24 now supports native windows in Win10

Created on 12 Oct 2017  路  11Comments  路  Source: Beep6581/RawTherapee

New update GTK3.22.24 now supports native windows in WIN10.

unbenannt

Most helpful comment

@heckflosse @Beep6581 Do you agree with this patch ? It sets minimum requirement for Gtk 3 to 3.22.24 for windows only :

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 01865fc..490cfa7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -266,10 +266,15 @@

 # Check for libraries:
 find_package(PkgConfig)
+if(WIN32)
+pkg_check_modules (GTK     REQUIRED gtk+-3.0>=3.22.24)
+pkg_check_modules (GTKMM   REQUIRED gtkmm-3.0>=3.22)
+else()
 pkg_check_modules (GTK     REQUIRED gtk+-3.0>=3.16)
+pkg_check_modules (GTKMM   REQUIRED gtkmm-3.0>=3.16)
+endif()
 pkg_check_modules (GLIB2   REQUIRED glib-2.0>=2.44)
 pkg_check_modules (GLIBMM  REQUIRED glibmm-2.4>=2.44)
-pkg_check_modules (GTKMM   REQUIRED gtkmm-3.0>=3.16)
 pkg_check_modules (CAIROMM REQUIRED cairomm-1.0)
 pkg_check_modules (GIO     REQUIRED gio-2.0>=2.44)
 pkg_check_modules (GIOMM   REQUIRED giomm-2.4>=2.44)

All 11 comments

@TooWaBoo Do you suggest that we should require this version for Windows ?

@Hombre57
Yes, I think this solves some issues witch we have with non native windows on WIN10. Everything works fine so far.

If needed I can rebuild 5.3

It works!!!
screenshot 42
screenshot 41

(It is css for gtk. I like black letters on white background.)

@chaotic-sys
Looks nice. 馃憤

@heckflosse @Beep6581 Do you agree with this patch ? It sets minimum requirement for Gtk 3 to 3.22.24 for windows only :

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 01865fc..490cfa7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -266,10 +266,15 @@

 # Check for libraries:
 find_package(PkgConfig)
+if(WIN32)
+pkg_check_modules (GTK     REQUIRED gtk+-3.0>=3.22.24)
+pkg_check_modules (GTKMM   REQUIRED gtkmm-3.0>=3.22)
+else()
 pkg_check_modules (GTK     REQUIRED gtk+-3.0>=3.16)
+pkg_check_modules (GTKMM   REQUIRED gtkmm-3.0>=3.16)
+endif()
 pkg_check_modules (GLIB2   REQUIRED glib-2.0>=2.44)
 pkg_check_modules (GLIBMM  REQUIRED glibmm-2.4>=2.44)
-pkg_check_modules (GTKMM   REQUIRED gtkmm-3.0>=3.16)
 pkg_check_modules (CAIROMM REQUIRED cairomm-1.0)
 pkg_check_modules (GIO     REQUIRED gio-2.0>=2.44)
 pkg_check_modules (GIOMM   REQUIRED giomm-2.4>=2.44)

@TooWaBoo Could you please test the Fullscreen button ? It doesn't restore to maximized properly when clicking on it again here.

Hmm... seems to work fine now, with your themes and RawTherapee theme. Don't know what happened.

@Hombre57
I don't have any issues with the fullscreen button.

@Hombre57 agreed. I already updated RawPedia based on #4125
http://rawpedia.rawtherapee.com/Windows

Patch committed. This Gtk version doesn't solve the curve issue from Retinex (beside others)... Closing.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Hombre57 picture Hombre57  路  3Comments

heckflosse picture heckflosse  路  4Comments

elecprog picture elecprog  路  5Comments

Thanatomanic picture Thanatomanic  路  3Comments

heckflosse picture heckflosse  路  5Comments