Rawtherapee: 5.3 crash in macOS when switching to Queue

[paulinster]

Hi, I have upgrade to RT5.3 but look like I can't put file to queue and then process them. When I click the queue tab, the application close and the crash report from mac os open.

Operating system: MacOS Sierra 10.12.6
Rawtherapee version: 5.3

Step to reproduce:

1. Open RT
2. From File Browser tab, put a 1-2 files to the queue
3. Click the queue tab

The application should then close and a popup from MacOS shoud appear saying "Rawtherapee qui unexpectedly" I have attach the crash report if this can be of any help ..

rawtherapee-bin_2017-10-02-211616_mtl-mac-lpaulin.crash.zip

If you require more information let me know!

[Benitoite]

Thanks for the crash report.
RT 5.3 doesn't crash for me in this way.
I can try rebuilding cairomm 1.12.2 though.

[Benitoite]

@paulinster See if this build makes any difference. Also try deleting your options file if you haven't already.
...

[paulinster]

The new build didn't change anything .. However I think that I found the
issues... Look like the issues is due to the directory naming... After
doing some test I found that I was able to add picture from other folders.
It turn out that the folder from which I was trying to add content to the
queue had french character. Once I rename the folder it work great...

Folder name I had issue with: "09-23 - Québec"

So look like the bug is rather that the application isn't handling properly
filename/directory with french character, most likely it could be the same
issues for other language as well..

--
!!!!!
( o o )
--------------oOO----(_)----OOo--------------
Luc Paulin
email: paulinster(at)gmail.com
Skype: paulinster

2017-10-03 0:48 GMT-04:00 Benitoite [e-mail]:

@paulinster https://github.com/paulinster See if this build makes any
difference. Also try deleting your options file if you haven't already.
https://filebin.net/qt0bb4y49yo2h3sc/RawTherapee_
OSX_10.9_64_5.3-2-gc6c9ad5e.zip

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Beep6581/RawTherapee/issues/4128#issuecomment-333738048,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AKVXZd5-A1ugO7N6ah7uQGKh1c9a3nvGks5soby2gaJpZM4PreR7
.

[Benitoite]

@paulinster Thanks. Reproduced crash as reported by renaming my folder to 09-23 - Québec.
@Floessie could this be another Glib::ustring locale convert error? I could not reproduce the crash in debug, so I have no backtrace.

[Benitoite]

@Floessie very similar crash as in https://github.com/Beep6581/RawTherapee/issues/3951#issuecomment-312648719

[Floessie]

@Benitoite

could this be another Glib::ustring locale convert error? I could not reproduce the crash in debug, so I have no backtrace.

We could tell for sure, if we had a backtrace. You can try to obtain one from a release build, though some symbols will be missing. What strikes me most is that it crashes with a release but not with a debug build. If we have a problem with the locales, I'd expect it to crash in both builds. And then still the question remains, why there are those locale problems at all, given the fact that everything is fine under Linux.

very similar crash as in #3951

Yes, the backtrace is similar, but I haven't found the solution to the crash in that issue. Maybe @heckflosse remembers? As such, it looked more like a race than a locale problem...

[Benitoite]

@Floessie Cannot reproduce any error with release running in lldb.
Release by itself, I can't get the same crash consistently. Sometimes it won't crash... then I get this error when trying to process the queue:

[Benitoite]

@Floessie Maybe I should try this: https://discuss.pixls.us/t/error-processing-queue-invalid-byte-sequence-in-conversion-input/1188/18?u=hiram

[Benitoite]

@paulinster https://filebin.net/t7fe4j4j0eq1ct2q/RawTherapee_OSX_10.9_64_5.3-2-gc6c9ad5e.zip
Here is another build with those changes https://github.com/Beep6581/RawTherapee/issues/4128#issuecomment-333966735 in the executable loader. I'm not getting a crash or error processing a folder named é as I was previously.

[paulinster]

@Benitoite Yeah the new build seem to have solve the issue I have successfully been able to put files in queue without a crash, even if the filename or path had french character...

Thanx for your help everyone...

[Floessie]

@paulinster Luc, thanks for reporting and testing!

@Benitoite Great investigation and quick solution! Thanks a lot! 👍

Merged.

[direvius]

Reproduces on RT 5.5 macOS 10.14.3 with cyrillic symbols in path.

[Benitoite]

@direvius can you post the system crash report?

[direvius]

raw_therapee_crash.txt.zip

[Benitoite]

Thanks. In 2 weeks I’ll be at home from overseas vacation and able to try things out. First thing to try is upgrading to the newest Cairo version, and add more quartz flags to its configuration.

[Beep6581]

Closing as duplicate of #4394 #4191