Rathena: MO_ExtremityFist doesn't double damage (Renewal)

[ecdarreola]

• rAthena Hash: 2e4ec1d

• Client Date: 20180621

• Server Mode: Renewal

• Description of Issue: MO_ExtremityFist doesn't apply skillratio += 100 if sphere count is more than 5.

  • Result: Same damage observed if sphere count is >|< 5
  • Expected Result: At sphere count > 5 it should double damage.
  • How to Reproduce: Compile renewal server -> allstats 130 -> use skill asura first without rising dragon to baseline damage -> use rising dragon and asura
  • Official Information:
    

• Modifications that may affect results: None
  
  

I also have tried modifying the code https://github.com/rathena/rathena/blob/2e4ec1d1f656daaad832033c31a8b6939cb8d266/src/map/battle.cpp#L3793

to: if(sd->spiritball > 5) and same result observed.

Not quite sure what does this do skillratio = min(500000,skillratio); //We stop at roughly 50k SP for overflow protection

[qwerty7vp]

Not quite sure what does this do skillratio = min(500000,skillratio); //We stop at roughly 50k SP for overflow protection

as it said it capped MO_EXTREMITYFIST
for maximum at 50k SP (500k% skill ratio)

[ecdarreola]

How does your test do? Does damage doubles if sphere count is > 5 ?

[LordWhiplash]

Hi, i've just tested, and you're right, bonus is not right...
The problem is related to this:

I mean, imagine you have 2k SP, this would mean your skill ratio would be = 100 * (7 + 2000/10), this is 20700% ATK, to be honest 20800% since the base 100% is included... when you add 100% for 6 or more spheres, it goes to 20900%, so, it seems no damage increase...

The bonus should be "skillratio += 100 + 100 * (7 + sstatus->sp / 10)", because "Increases damage by 100% when there are 6 spirit sphere or more remains." is meant to DOUBLE the skill ratio, not add 100. Of course it needs to be discuted, it is about text interpretation.

I've applied this changes to test, and seems right now.

To be honest, i would like to have some kind of information if the MO_EXTREMITYFIST skill ratio is right, because it is VERY HIGH.

[aleos89]

Yeah it was a quick misinterpretation from me thinking just a +100 to the rate.