Rasa: Rename `master` branch to a neutral term
Proposed Change
To reflect the values of Rasa and our community, we should rename the master branch to a neutral term. Other projects have undertaken similar efforts.
Useful source
https://github.com/github/renaming
Things to change
- [ ] rename branch. Potential candidates are
main,default - [ ] adapt CI pipeline checks to test for this new branch name instead of
master - [ ] check codebase for problematic naming (such as
whitelisting,blacklisting) - [ ] adapt links in docs / changelog / readme to
mastertree - [ ] adapt badges in
Readme.mdto use new branch name - [ ] adapt required checks in GitHub settings to match new branch name
- [ ] ?? the docs currently refer to
masteras well as to the tagged version. Do we have to change something here? - [ ] Any other candidates which we have to check?
Things which should be fine
- our Docker builds since they are running as part of the CI now (we are not longer using dockercloud)
wochinge
All 5 comments
Be advised that renaming the branch actually deletes it, so I'm pretty sure all the pull requests associated with the current main "master" will get closed if you do so! This has happened on other open source projects that took this step a little too impulsively.
I'm not sure you'll be able to associate them to the new branch easily, I guess you could script that with the github api though.
Just throwing some ideas: Maybe it would help instead of renaming "master", create a (new) "main" branch, associate the "master" pull requests to that branch and then delete "master". It would need testing through, i get the feeling you will still loose the discussions ongoing on said pull requests/reviews .
karen-pal
on 26 Jun 2020
Hey @karen-pal ,
thanks for your support and helpful insights! 馃檹
@ricwo I was you added the discussion label. What is missing to move forward with this?
wochinge
on 26 Jun 2020
@wochinge mainly the choice of a new branch name - main, default - something else?
ricwo
on 26 Jun 2020
Or development or stable?
wochinge
on 27 Jun 2020
wochinge
on 22 Jul 2020
Related issues
Arghya999
路
3Comments
irfan-zoefit
路
3Comments
jahid-ict
路
3Comments
nicolasfarina
路
3Comments
johnson7788
路
3Comments
Most helpful comment
Be advised that renaming the branch actually deletes it, so I'm pretty sure all the pull requests associated with the current main "master" will get closed if you do so! This has happened on other open source projects that took this step a little too impulsively.
I'm not sure you'll be able to associate them to the new branch easily, I guess you could script that with the github api though.
Just throwing some ideas: Maybe it would help instead of renaming "master", create a (new) "main" branch, associate the "master" pull requests to that branch and then delete "master". It would need testing through, i get the feeling you will still loose the discussions ongoing on said pull requests/reviews .