Ransack: Rename `master` to `main`

Created on 27 Nov 2020  路  7Comments  路  Source: activerecord-hackery/ransack

Most helpful comment

@yshmarov I know we don't _need_ to do it, but I think @seanfcarroll is bringing this up as something that we _want_ to do.

All 7 comments

This is for new repositories. Old ones don't have to be renamed

@yshmarov I know we don't _need_ to do it, but I think @seanfcarroll is bringing this up as something that we _want_ to do.

At the technical level, a lot of libraries use master as the default branch name, renameing it to main may lead to unintended results.

gem 'ransack', github: 'activerecord-hackery/ransack'

For example, in Gemfile, this will fetch from master branch, not main branch, so I think we don't need to do it.

https://github.com/rubygems/rubygems/blob/53a1673b8edae04f0190c30506facd6b4c1e1f72/bundler/lib/bundler/source/git.rb#L25

Yes, I don't plan to change this at all unless we fix https://github.com/rubygems/rubygems/issues/4009 first and make sure that proper redirections are in place for the transition.

@deivid-rodriguez I see https://github.com/rubygems/rubygems/issues/4009 is closed, is it fixed now ? (wasn't clear to me in the issue).

Yes, this should be fixed now and released with bundler 2.2.5 (https://github.com/rubygems/rubygems/blob/3.2/bundler/CHANGELOG.md#225-january-11-2021). Obviously unless clients have upgraded to that version, they won't benefit from the fix.

Obviously unless clients have upgraded to that version, they won't benefit from the fix.

Let's give it a few more months then.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ivanovaleksey picture ivanovaleksey  路  3Comments

tagrudev picture tagrudev  路  3Comments

timoschilling picture timoschilling  路  5Comments

seanfcarroll picture seanfcarroll  路  4Comments

JFimex picture JFimex  路  3Comments