Radium: [Tracking] 'git clone' + [email protected] install fails on sinon peerDeps

[MylesBorins]

Looks to be an issue with peer deps

> cd lib || npm run build

npm ERR! Darwin 16.7.0
npm ERR! argv "/Users/mborins/.nvm/versions/node/v4.8.6/bin/node" "/Users/mborins/.nvm/versions/node/v4.8.6/bin/npm" "i"
npm ERR! node v4.8.6
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants sinon@^1.4.0 || ^2.1.0 || ^3.0.0 || ^4.0.0
npm ERR! peerinvalid Peer [email protected] wants sinon@^2.1.0 || ^3.0.0 || ^4.0.0

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/mborins/code/radium/npm-debug.log

[ryan-roemer]

@MylesBorins -- How are you taking the dependency on radium? Or are you trying to git clone the project and work on it?

The npm version is rewritten to not even contain postinstall -- https://unpkg.com/[email protected]/package.json while the git version does have a postinstall -- https://github.com/FormidableLabs/radium/blob/master/package.json#L16 but that shouldn't hit sinon as an invalid peer since it's a devDependencies.

[MylesBorins]

git cloning the repo then running npm install

[ryan-roemer]

OK. I'll take a look at that.

[ryan-roemer]

What node + npm versions are you on?

It worked for me with:

$ node --version && npm --version
v4.8.4
5.5.1

Although I did have to run npm run build after npm install because it didn't run the postinstall command but still exited 0.

Can you try with yarn? That's what all the folks on this project use for development of the library itself...

[MylesBorins]

So we found this when testing with npm v2.15.11 the version that comes bundled with node v4.8.4

[ryan-roemer]

Reproduced and verified with:

$ node --version && npm --version
v4.8.4
2.15.11

Error steps:

$ npm install
# ... SNIPPED ...


> [email protected] postinstall /Users/rye/scm/fmd/radium
> cd lib || npm run build

npm ERR! Darwin 14.5.0
npm ERR! argv "/Users/rye/.nvm/versions/node/v4.8.4/bin/node" "/Users/rye/.nvm/versions/node/v4.8.4/bin/npm" "install"
npm ERR! node v4.8.4
npm ERR! npm  v2.15.11
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants sinon@^1.4.0 || ^2.1.0 || ^3.0.0 || ^4.0.0
npm ERR! peerinvalid Peer [email protected] wants sinon@^2.1.0 || ^3.0.0 || ^4.0.0

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/rye/scm/fmd/radium/npm-debug.log

The unfortunate thing here is that supporting ancient npm for git clone + npm install is going to be very low priority (as opposed to say to an issue in node4 with an npm dependency). We'll definitely accept a PR that works for everything in our CI matrix with an upgrade, but we're unlikely to take specific action on this issue. Most likely, we'll eventually do a mass dependencies update to everything and it will resolve this issue then.

If you have a specific use case that you need this combination of tools to work with, then perhaps we can help with it. But otherwise, thanks for reporting the issue, and we'll eventually, hopefully get to it! 😄

[MylesBorins]

Just wanted to let y'all know about this. v4.x is EOL in a couple months so it isn't a priority

[kylecesmat]

Closing this since v4.x has reached end of life as of 2018-04-30 - https://github.com/nodejs/Release