Radare2: Use git subtree for dependencies

[xarkes]

Hello,

I think it would be easier to handle the dependencies in radare2 (mostly shlr/ folder) if we were using git submodules.
I think copy pasting is a bad practice and that we should use better development practices.

[EDIT] Actually I believe using git subtree is much better for our needs.

[radare]

how many times we had this discussion? are you sure there's no other issue to track this? anyone tried to ask github to support submodules in the release tarballs? i dont want to push my own tarballs. also managing submodules will be a pain for many users, even if its good practices will introduce many new issues for many users. So until github doesnt supports it i dont have any plan in switching to submodules

[xarkes]

I don't want to push my own tarballs.

Fortunately in 2018 there are tools such as Travis which can do that for you. Not an issue from my PoV.

[radare]

Travis fails pretty frequently, and delegating the responsability to create tarballs to a third party implies a security issue in the distribution stage. also extra work to maintain/setup.

why not just mail github and ask for this feature

On 4 Oct 2018, at 15:01, xarkes [e-mail] wrote:

I don't want to push my own tarballs.

Fortunately in 2018 there are tools such as Travis which can do that for you. Not an issue from my PoV.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/11730#issuecomment-427009455, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lg9JUjsmcEKlpbpNgFpNxTZdxAlxks5uhgaYgaJpZM4XICIO.

[xarkes]

@Maijin asked and there is no answer for now.
I think he should ping them again.

[radare]

sgtm

On 4 Oct 2018, at 16:13, xarkes [e-mail] wrote:

@Maijin https://github.com/Maijin asked and there is no answer for now.
I think he should ping them again.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/11730#issuecomment-427034924, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lpgoreYhe1XA3UsjcijD5wUFrcn4ks5uhhefgaJpZM4XICIO.

[xarkes]

A friend of mine just learned me too alternatives:

• git sub-tree
• git-subrepo

Those are worth checking out.

[Maijin]

wait, maybe sub-tree can fix the issue though because as @xarkes explain, it's a copy just like we have now.

[Maijin]

I created a test-case for subtree here:

• https://github.com/Maijin/testsubtree
  And published a release here:
• https://github.com/Maijin/testsubtree/releases/tag/1.0

The release contains the subtree in Github:

[radare]

Another reason for not using submodules is because we will miss all the static source code analysis reports from Coverity. That's how i found many vulns in capstone, grub, gnu binutils, zip, .... we can't register more projects there

[Maijin]

@radare have you read the proposed solution with subtree?

[radare]

nope, im just focusing on the release. and this is not going to be in this release

On 12 Oct 2018, at 13:28, Maijin [e-mail] wrote:

@radare https://github.com/radare have you read the proposed solution with subtree?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/radare/radare2/issues/11730#issuecomment-429294659, or mute the thread https://github.com/notifications/unsubscribe-auth/AA3-lsw3PP6V_QFG-3pJ4xct3dlHy-pCks5ukHztgaJpZM4XICIO.

[Maijin]

So when you have time, read my message below then comment because this "we will miss all the static source code analysis " is not a problem with git subtree.

[Maijin]

Seems like we're moving towards submodules see #15497

[radare]

any volunteer?

On 2 Dec 2019, at 22:13, Maijin [e-mail] wrote:

Seems like we're moving towards submodules see #15497 https://github.com/radareorg/radare2/issues/15497
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/radareorg/radare2/issues/11730?email_source=notifications&email_token=AAG75FTKNG2OWJW6YZX556DQWV3BBA5CNFSM4FZAEIHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFU5FKY#issuecomment-560583339, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG75FR5C4IB5U4GEXO4XYLQWV3BBANCNFSM4FZAEIHA.