Radare2: Typo in String search

[ziyaddin]

When I use the command r2 -q -c "/ a" my_file, it gives a result like:

Searching 1 bytes from 0x00000000 to 0xffffffffffffffff: 61 
Searching 1 bytes in [0x400000-0x40220c]
hits: 15
Searching 1 bytes in [0x602e08-0x603048]
hits: 0
Searching 1 bytes in [0x603048-0x603060]
hits: 0

As you can see, it indicates 1 bytes instead of 1 byte. I observed that it is related to this line:
https://github.com/radare/radare2/blob/e985e0b9edb54d7d07584367db2aadc0c58112fe/libr/core/cmd_search.c#L2076

[radare]

Just send a pr. Click the pencil button in github

On 12 Dec 2017, at 08:42, Ziyaddin Sadigov [e-mail] wrote:

When I use the command ``, it gives a result like:

As you can see, there is a typo 1 bytes which
I observed that it is related with this line:
https://github.com/radare/radare2/blob/e985e0b9edb54d7d07584367db2aadc0c58112fe/libr/core/cmd_search.c#L2076

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[ziyaddin]

Sure. I will work on it.

[ziyaddin]

@radare how can I test my code update?

[radare]

Test a typo? Wat

On 12 Dec 2017, at 21:11, Ziyaddin Sadigov [e-mail] wrote:

@radare how can I test my code update?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[ziyaddin]

I am asking generally. As I am new to this repo, I don't know how exactly I can test (execute) my local file changes? I have read the documentation, but there is no sufficient info for that.

[xarkes]

make ?

[ziyaddin]

Thank you @xarkes!

[radare]

any update?

[radare]

tired of waiting. fixed in master

[ziyaddin]

You just waited for my fix these 6 days? :smiley: anyways, you have better fix than mine

[radare]

I did the fix yesterday because i needed for a script i was doing. There are still things to do, so im not closing the issue. Release will be next week, so if you are in the mood to get this PR in time it will be included in 2.2

Thanks!

On 18 Dec 2017, at 16:30, Ziyaddin Sadigov [e-mail] wrote:

You just waited for my fix these 4 days? 😃 anyways, you have better fix than mine

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

[ziyaddin]

@radare it seems that many files have this "byte/bytes" issue. Should we focus only on this file or all of them?

[radare]

Maybe we should just use byte(s) and avoid that conplexity

On 24 Dec 2017, at 07:34, Ziyaddin Sadigov [e-mail] wrote:

@radare it seems that many files have this "byte/bytes" issue. Should we focus only on this file or all of them?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[ziyaddin]

Nice point. Will work on that.

[ziyaddin]

@radare made a PR for that #9067

[radare]

Yeah saw that. Will check tomorrow

Thanks!

On 24 Dec 2017, at 20:02, Ziyaddin Sadigov [e-mail] wrote:

@radare made a PR for that #9067

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.