Radare2: Changing immediate base does not work in all cases.

[MariasStory]

ahi s or Vdi 2 on some instructions do not change the right operation parameter

Good example:

Wrong behavior.
Before:

After:

[Maijin]

Can you create test for this behavior:

https://github.com/radare/radare2-regressions/blob/master/t/cmd_ahi

[MariasStory]

Done.
https://github.com/radare/radare2-regressions/pull/520

Please check.

[radare]

the replacing code should ignore numbers inside brackets . can you take a look @alvarofe ?

[alvarofe]

yeah sure ;)

[crowell]

Uh, not just within brackets, it should be optional to change them there IMO

On Aug 25, 2016 4:07 PM, "Álvaro Felipe Melchor" [email protected]
wrote:

yeah sure ;)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/radare/radare2/issues/5608#issuecomment-242519224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlnYKipYbHIGPzr0G3wiIxjZfQnO8R3ks5qjfXYgaJpZM4JtBdB
.

[crowell]

Each num should be individually addressable

On Aug 25, 2016 4:10 PM, "Jeff Crowell" jeff.[email protected] wrote:

Uh, not just within brackets, it should be optional to change them there
IMO

On Aug 25, 2016 4:07 PM, "Álvaro Felipe Melchor" [email protected]
wrote:

yeah sure ;)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/radare/radare2/issues/5608#issuecomment-242519224,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAlnYKipYbHIGPzr0G3wiIxjZfQnO8R3ks5qjfXYgaJpZM4JtBdB
.

[MariasStory]

@crowell do you have an example for the case where a number in brackets should be changed?

We most probably have to have an option to set which argument should be set to specific base.

Also, should't such case of variable usage be commented with a string value of the variable in comment, after analyze?

[alvarofe]

What about something like ahi s 2 where the 2 is the second number in the expression or if you want the first one either ahi s or ahi s 1?

[MariasStory]

Why not ahi s do both parameters and ahi s1 or ahi s2 do the specific.
The Vdi 2 also could follow the same theme Vdi 21 and Vdi 22.
Any better calls?

[radare]

I would go for ahi2 ahi3..

On 26 Aug 2016, at 10:27, MariasStory [email protected] wrote:

Why not ahi s do both parameters and ahi s1 or ahi s2 do the specific.
The Vdi 2 also could follow the same theme Vdi 21 and Vdi 22.
Any better calls?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[MariasStory]

OK. Agree. This would be better.

ahi - change all parameters.
ahi1 - change first parameter.
ahi2 - change second parameter.

Example: ahi2 s.

[Maijin]

don't forget to update visual mode then

[radare]

Imho ahi should change the immediate only. And mov [eax+3], 45 only have 1 immediate. This should be the way to go by default. We can later add ahi1, ahi2.. To specify which number exactly, but this will be more work

On 26 Aug 2016, at 11:53, MariasStory [email protected] wrote:

OK. Agree. This would be better.

ahi - change all parameters.
ahi1 - change first parameter.
ahi2 - change second parameter.

Example: ahi2 s.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

[Maijin]

Related to https://blog.didierstevens.com/2016/09/30/quickpost-enhancing-radare2-disassembly-listing/#comment-358540 too

[Maijin]

https://blog.didierstevens.com/2016/09/30/quickpost-enhancing-radare2-disassembly-listing sorry

[radare]

Fixed in https://github.com/radare/radare2/pull/12494

[Maijin]

Amazing!