Rack: Don't move module after dragging from Module Browser if mouse delta is lower than some threshold

[Miserlou]

Since upgrading to 1.0+, I've noticed a small annoying UI change.

Previously, I would right-click on a space where I wanted to place a module, then select it from the menu, and it would appear where I had initially right-clicked.

Now, I right click where I want to place a module, then the menu appears, but the module is placed _in the last place I clicked on the menu_, which is usually at the top of the screen, above the level of the rack where I'm trying to place it.

This ends up being quite frustrating, especially as the behavior was perfect before.

[Miserlou]

Here is an example: https://i.imgur.com/z0ox5ju.mp4

[AndrewBelt]

That's because "the last place I clicked on the menu" is where you first start dragging the module.

[Miserlou]

That might be what's going on under the hood, but I still think this is a regression, since the behavior was much more intuitive in 0.6 rather than 1.0. I don't want to "drag" to place a new module, I simply want to place it where I initially clicked. This is especially true because it's extremely unintuitive that clicking to select a module from the menu is actually the start of a "drag" motion. I'd suggest we make it such that if that if selecting a module isn't a click-and-hold action, set the starting coordinates to where the menu opened, unless the module is held, in which case start the drag.

[limstepf]

This bothers me too. I don't even understand the rules for how new modules are placed down now. Sometimes its above, sometimes way off to the side. Having to search for the new module you've just placed down (in an already busy patch) is just terrible. The old mechanism worked just lovely. What happened?

[AScustomWorks]

I had the same feeling until I read this text... after that, is just a small adjustment, and so worth it compared to the old behavior once you adjust to it;) :

[limstepf]

Ah, now I understand (sorry for my ignorance). This makes perfect sense for using the graphical browser. My problem is that I am still trying to use it mostly by keyboard: type until what you need shows up and hit enter. But that doesn't really work anymore in 1.0 anyways. Two thoughts:

1) Wouldn't it make sense to get the old placement algorithm back in case no dragging action has been started by the user from the graphical browser? That is, when the user just clicks on a module in the graphical browser, or his "drag" is shorter than some tiny threshold (say just a few pixels in dragging distance, or just a few ticks in time).

2) Text interface > graphical browser for your everyday use. It's just so much faster and more responsive. The graphical browser surely got its advantages in discovery of new, or not often used modules. But should it really be the main interface for an action used this often?

[AndrewBelt]

@limstepf Enter selects the first module and places it at the last hovered Rack position.

[Miserlou]

FWIW, the behavior @limstepf is describing is exactly what I want and what I'd expect. Not trying to nag and I know you're on holiday, but I think this might warrant wider discussion to see what other people expect.

[AndrewBelt]

Reopening with slightly different scope.
The difficulty is adding this feature without breaking ABI, so we may have to wait for v2.