Rabbitmq-server: rabbitmq-amqp1.0-client: publish hex package

[patrickdet]

Hey all,

great library, thank you so much for it. This might not be the place for it but would it be possible to get this library published on hex.pm? It's really hard for me to get it's to build properly from Elixir. A simple: {:amqp10_client, github: "rabbitmq/rabbitmq-amqp1.0-client", compile: "make"} in the mix.exs file leads to make errors whereas building it from the the rabbitmq-amqp1.0-client root folder works without a hitch. I suspect that the rabbitmq_codegen stage is problematic here. Have you considered publishing the package on Hex?

Thanks again :)

[patrickdet]

I have posted to the mailing list https://groups.google.com/forum/#!topic/rabbitmq-users/dSNrYUh8HRI as well and opened a repo https://github.com/patrickdet/amqp1.0_elixir_issue showcasing the issue. Any help would be appreciated but I understand if this is not the place.

[michaelklishin]

We publish our AMQP 0-9-1 Erlang client to Hex.pm, so it makes sense to publish this one. Maybe after 3.7.4 is out.

[kjnilsson]

For now would it help if we committed a rebar.config? You can test it by generating first using make rebar.config

[lukebakken]

Hi @patrickdet

Thank you for providing a repository to try to reproduce the issue you're seeing (https://github.com/patrickdet/amqp1.0_elixir_issue). I cloned it, and ran the same commands as you did, and everything appeared to work correctly. I am using Erlang 19.3 and Elixir 1.6.1 on Arch Linux,

I have attached a transcript to this comment.

transcript.txt

[lukebakken]

Re-opening since this issue is actually about publishing to hex.pm :smile:

[patrickdet]

Woah you folks are fast! thank you for getting back to me.

I have tried generating the rebar.config like @kjnilsson suggested but it leads to Uncaught error in rebar_core errors with with an unhelpful stacktrace.

@lukebakken I am running macOS with Erlang/OTP 20 and Elixir 1.6.0. I am surprised that you had no issues :/ I will try different Erlang versions now and report back.

Thank you for being open to the idea of publishing the package maybe with the next release. That would be amazing really.

[michaelklishin]

@patrickdet consider posting actual messages in the future. Our team does not use GitHub issues for discussions. We understand the scope of this issue and it is actionable, all other discussions belong to the mailing list.

[lukebakken]

I am running macOS with Erlang/OTP 20 and Elixir 1.6.0. I am surprised that you had no issues :/

Is the make executable in your PATH the default, BSD-make or GNU-make? On my OS X laptop, I have homebrew-installed gmake aliased as make by my shell to avoid issues like this. All of the RabbitMQ make files assume that GNU make is being used.

[michaelklishin]

Here's my run on MacOS High Sierra and on Erlang 20.1. I doubt it would be any different with 19.3.6 or 20.2. We may get a chance to automate hex.pm releases next week.

[patrickdet]

@michaelklishin ahh ok, at least you can reproduce the issue, great! thank you for your feedback i will use the mailing list in the future.

@lukebakken yeah GNU make is in my path and before system make. I am using the same homebrew aliasing trick as you.

[blueredlabs]

@patrickdet I had very similar situation as yours. I tried to build the package and dep.compile has failed caused by missing Makefile of a dependency of amqp1.0-client

Later, I figured out my system doesn't have rebar on Ubuntu. after install with below command, all compiled sucessfully.

sudo apt-get install rebar

[michaelklishin]

@blueredlabs thank you for sharing this. It's definitely not always obvious what the root cause is with make (or at least the extensive make-based system we have accumulated).

[cjbottaro]

Using in my mix.exs:

{:amqp10_client, github: "rabbitmq/rabbitmq-amqp1.0-client", tag: "v3.8.4", compile: "make"}

It compiles, but starting up iex fails:

** (Mix) Could not start application amqp10_common: could not find application file: amqp10_common.app

Not sure how to resolve. Can we get a Hex package?

[bettio]

Any update on this issue? I'm experiencing the same kind of issues:

** (Mix) Could not start application amqp10_common: could not find application file: amqp10_common.app

[bettio]

{:amqp10_common, github: "rabbitmq/rabbitmq-amqp1.0-common"} should be explicitly added to mix.exs.

Therefore mix.exs should have both:

{:amqp10_common, github: "rabbitmq/rabbitmq-amqp1.0-common"},
{:amqp10_client, github: "rabbitmq/rabbitmq-amqp1.0-client"}

[kjnilsson]

@bettio thanks - would you mind submitting a PR for it?