Steps for Reproduction
``` + \Expected behavior:
You should be able to exit the code block.
Actual behavior:
Nothing happens. It feels like you鈥檙e stuck and there鈥檚 no way to exit the code block.
I only discovered later, by accident, that you can exit the block by pressing \ Platforms: Tested on latest Safari, on latest macOS. On latest iOS. Version: Not sure what version the online demo is running. Original issue (closed) on the module鈥檚 issue tracker: https://github.com/patleeman/quill-markdown-shortcuts/issues/9#issuecomment-368898924
I'd like to elaborate a little bit on this issue.
The issue seems to stem from not already having a newline after the current CodeBlot.
Expected behavior:
A newline will be inserted after the CodeBlot if it is the last element in the document. The user's cursor will then be placed on that line.
I'm willing to make a PR for this.
If you take a look here I have a functioning implementation of this behaviour for multiple of our Custom Blots for both the beginning and end of the document with all arrow keys.
@jhchen Is this something you would accept a PR for, for the built in CodeBlock and BlockQuote Blots?
Hi, @charrondev has there been any movement on this issue? I think PRs to address this issue and https://github.com/quilljs/quill/issues/1978 would be awesome.
I realize now that the link I shared has been made defunct after the branch it was on was deleted. I'm willing to submit a PR for both this and #1978 with tests, but was looking for acknowledgement form @jhchen first.
In the meantime you can find our implementation and tests
Those files also use a few utilities I've written for:
They are written in typescript though, but it should be easy enough to read through. We have a decent amount of custom blots, and don't use all of the built in ones though, so there is probably a lot of extra code happening there. Our for quotes supports multiple lines, so we have some additional handlers for better UX in that department.
Hi team,
Any update related to this issue?
Most helpful comment
I realize now that the link I shared has been made defunct after the branch it was on was deleted. I'm willing to submit a PR for both this and #1978 with tests, but was looking for acknowledgement form @jhchen first.
In the meantime you can find our implementation and tests
Those files also use a few utilities I've written for:
They are written in typescript though, but it should be easy enough to read through. We have a decent amount of custom blots, and don't use all of the built in ones though, so there is probably a lot of extra code happening there. Our for quotes supports multiple lines, so we have some additional handlers for better UX in that department.