Quartznet: Consider making the new internal QuartzOptions properties public

Created on 2 Oct 2020  路  7Comments  路  Source: quartznet/quartznet

Hey @lahma,

Would it be possible to make the 3 properties that are currently internal public? It would help a lot with unit tests (to ensure job and trigger details are correctly registered by an IConfigureOptions<QuartzOptions> class).

Thanks!

picture kevinchalet

All 7 comments

There's now public readonly getters for Triggers and Jobs, I've removed the Calendar for now as it wasn't even used.

lahma picture lahma on 2 Oct 2020
🚀1

Thanks!

kevinchalet picture kevinchalet on 2 Oct 2020

Wooops, I suspect you forgot to make the properties "public": https://github.com/quartznet/quartznet/commit/94a4f33968a259f7f2d9f37e62f79ebad58455da#diff-baab1cc10703ed0030c47a179783803aR36 馃槄

kevinchalet picture kevinchalet on 2 Oct 2020

Oh dear...

lahma picture lahma on 2 Oct 2020
😄1

Now is should be in master, this time for real... 馃う

lahma picture lahma on 3 Oct 2020

Hey @kevinchalet I just published 3.2.1 to NuGet and this time I hope I got the visibility modifier correct 馃槈

lahma picture lahma on 18 Oct 2020

@lahma awesome, thanks! I can confirm they are now really "public" 馃槃
https://github.com/openiddict/openiddict-core/pull/1137

kevinchalet picture kevinchalet on 18 Oct 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Pinguwien picture Pinguwien  路  6Comments
ljani picture ljani  路  9Comments
lahma picture lahma  路  19Comments
ndenkha picture ndenkha  路  14Comments
lucamazzanti picture lucamazzanti  路  15Comments