Quarkus: NullPointerException with HibernateValidator @Valid

Created on 17 Mar 2020 · 15Comments · Source: quarkusio/quarkus

Describe the bug

Validator annotations can be placed to various places. Example this is probably not effective:

public class StringBasedIdentity implements Serializable, Comparable {

private static final long serialVersionUID = 1L;

@NotNull
@NotEmpty
private final String name;

...

}

Expected behavior
Quarkus processor should be able to pinpoint the error with at least the location of the annotation should be provided as a hint.

Actual behavior
[ERROR] Failed to execute goal io.quarkus:quarkus-maven-plugin:1.2.1.Final:build (default) on project sched-schedule-app: Failed to build a runnable JAR: Failed to augment application classes: Build failure: Build failed due to errors
[ERROR] at io.quarkus.hibernate.validator.deployment.HibernateValidatorProcessor.build(HibernateValidatorProcessor.java:191)
[ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[ERROR] at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[ERROR] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[ERROR] at java.lang.reflect.Method.invoke(Method.java:498)
[ERROR] at io.quarkus.deployment.ExtensionLoader$2.execute(ExtensionLoader.java:915)
[ERROR] at io.quarkus.builder.BuildContext.run(BuildContext.java:279)
[ERROR] at org.jboss.threads.ContextClassLoaderSavingRunnable.run(ContextClassLoaderSavingRunnable.java:35)
[ERROR] at org.jboss.threads.EnhancedQueueExecutor.safeRun(EnhancedQueueExecutor.java:2011)
[ERROR] at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.doRunTask(EnhancedQueueExecutor.java:1535)
[ERROR] at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1426)
[ERROR] at java.lang.Thread.run(Thread.java:748)
[ERROR] at org.jboss.threads.JBossThread.run(JBossThread.java:479)

To Reproduce
Steps to reproduce the behavior:

Create file
Run build

Environment (please complete the following information):

Quarkus version 1.2.1

kinbug

Source

smil2k

All 15 comments

Could you provide a reproducer? thanks.

gsmet on 17 Mar 2020

Hi,

Would you be able to see if 1.3.0.Final (you'll have to switch to quarkus-bom instead of quarkus-universe-bom unless you test tomorrow when the latter should also be available) exhibits the same behavior?

geoand on 18 Mar 2020

Hi,

Strange it seems that I'm no longer able to reproduce it.
I'll reopen the ticket if comes back.

I'm having a multi project setup with jandex on all dependencies.
I had to remove some @Valid on method parameters.

Maybe I hit this remark:
// FIXME this won't work in the case of synthetic parameters
(Project is using lombok)

Cheers,

Tamas

smil2k on 18 Mar 2020

I had to remove some @Valid on method parameters.

You shouldn't have to do that.

So, if you do, please open issues with reproducer and I'll have a look.

Thanks!

gsmet on 18 Mar 2020

I think we really need a reproducer, because looking at the stacktrace, there should never be NPE at that point.
So perhaps there is some corner case we haven't accounted for and which your reproducer would uncover :)

geoand on 18 Mar 2020

I tried to create one, but I failed. Maybe if I'm hitting it again, I'll reopen this case.

smil2k on 18 Mar 2020

👍1

Hello @smil2k , I have the same problem, project Quarkus parent A with Quarkus submodule B. If I run project B with @Valid there are no problems, but when added as a maven dependency the same error occurs.