It should be displayed once per Quarkus dev run. And probably not in tests.
And be overridable for the usΓ’mes like Keycloak with a small powered by Quarkus subline.
CC @cescoffier
Can we do this on project creation instead of on every startup?
You see the asciiart once you might think its cool, you see it multiple times a day every day then it is basically just noise, and reducing logging noise was one of the design goals.
I donβt believe it will be noise. It will be a useful visual marker to know when/where quarkus started and make it instantly recognizable.
I agree it should be as small as possible but more than just one line :)
I don't think project creation is enough but +1 for an option to hide for allergic folks.
inspiration/partial implementation: https://github.com/quarkusio/quarkus-workshops/tree/master/quarkus-workshop-super-heroes/extensions/extension-banner
hello. I would like to take this beginner issue to work upon.
@KaenDagger sounds good - we don't assign "ownership" of issues per say - best is if you open a Pull-request with your proposal then you'll get feedback from there.
Do I also have to implement the banner as extension just like in the quarkus-superheroes-workshop ?
Good question @KaenDagger. Yes try and do so. But it might be an extension we always add and will need to interact witht he Quarkus messages we see at boot (Quarkus version etc).
reopening as banner isn't actually hooked up.
currently you can do:
./mvnw quarkus:add-extension -Dextensions=banner
and you get the nice banner.
Optimally this should be default enabled imo, but a few things are missing:
quarkus.banner.enabled=false
)optimally but not required, right align of the "tag/line" (right now its just printed on the left.
Optimally this should be default enabled imo, but a few things are missing:
- an option to turn the banner off (
quarkus.banner.enabled=false
)
This is covered by: https://github.com/quarkusio/quarkus/pull/7478
I am not sure what you are referring to by tag/line and version but it seems the banner idea has deviated compared to early conversations.
We wanted
βββββββ βββ βββ ββββββ βββββββ βββ ββββββ βββββββββββ βββ βββ
ββββββ ββββββββββββ ββββββββββββββββββββββ βββββββ βββββββββββ ββββββββ
ββββββ βββ ββββββ ββββββββββββββββββββββββββ βββ βββββββββββ ββββββββ
ββββββ βββββ ββββββ ββββββββββββββββββββββββββ βββ βββββββββββ ββββββββ
ββββββ βββββββββββββββββββββ ββββββ ββββββ ββββββββββββββββββββ ββββββββ
βββββββ βββββββ βββ ββββββ ββββββ βββ βββββββ ββββββββ βββ βββ
Powered by Quarkus 1.3.0.Final
BTW what does the :: and >> around Quarkus mean in :: Quarkus >>
?
tagline was the :: Quarkus :: 1.3.0.Final
in place now. i think it follows the convention others used here but i'm fine with "Powered by Quarkus ${quarkus.version}" right aligned and make the banner text the thing that can be overridden.
Tag line :: Quarkus:: 1.3.0.Final
was inspired from spring banner.
Regarding banner text :: Quarkus >>
. It kinda looks like rocket moving forward with Quarkus written inside it. Originally I wanted rocket in which qurakus is written .
So banner idea According to me was a rocket with Quarkus written inside it
. Rocket represented speed and powerful.
But I was unable to make that ASCII art properly
@emmanuelbernard
I suppose original concerns are addressed.
:: Quarkus :: ${project.version}
is there .@KaenDagger the ask is to make the label "Powered by Quarkus {version}"
Ignore my suggestion on putting appname and tagname overrides in.
Right and figuring out how we can make this on by default.
Label could be easily changed. But currently I have got the idea of new banner. Could I change the label with new banner.txt PR ?
Also this week I would be busy for my college exams. So would be able to work from next week
Agreed that we should move this extension to core.
Do we remove quarkus-extension from 1.3 to not have anything overlapping ?
I'll update my banner PR to move it to the core in a few minutes
@KaenDagger the ask is to make the label "Powered by Quarkus {version}"
Ignore my suggestion on putting appname and tagname overrides in.
How did you manage to change the tagline?
I cannot find any property here https://quarkus.io/guides/all-config to change it
It's not configurable at the time being
It's not configurable at the time being
I see. Too bad...
Most helpful comment
Can we do this on project creation instead of on every startup?
You see the asciiart once you might think its cool, you see it multiple times a day every day then it is basically just noise, and reducing logging noise was one of the design goals.