Quarkus: Add support for timeouts, ssl and other %s/mp-rest/* config properties for MicroProfile RestClient

Created on 3 Oct 2019 · 9Comments · Source: quarkusio/quarkus

Description

Would be nice to have possibility to configure rest-client(s) timeouts and key store(s) with configuration parameters in quarkus.

MP rest client have config properties for timeouts
https://download.eclipse.org/microprofile/microprofile-rest-client-1.3/microprofile-rest-client-1.3.html#_configuration_keys

%s/mp-rest/connectTimeout
%s/mp-rest/readTimeout

and for trust/key store
https://download.eclipse.org/microprofile/microprofile-rest-client-1.3/microprofile-rest-client-1.3.html#ssl

%s/mp-rest/trustStore
%s/mp-rest/trustStorePassword
%s/mp-rest/trustStoreType
%s/mp-rest/hostnameVerifier
%s/mp-rest/keyStore
%s/mp-rest/keyStorePassword
%s/mp-rest/keyStoreType

Implementation ideas

New to quarkus so not sure, but maybe io.quarkus.restclient.runtime.RestClientBase should do like org.jboss.resteasy.microprofile.client.RestClientDelegateBean or just use it.

arerest-client kinenhancement

Source

doroshevich

Most helpful comment

Hi @lhauspie this is okay and your contribution is highly welcomed. Consider the issue yours. Feel free to ping us if you a helping hand on it.

machi1990 on 3 Oct 2019

👍2

All 9 comments

I would like to work on this one...
Is it OK ?

lhauspie on 3 Oct 2019

Hi @lhauspie this is okay and your contribution is highly welcomed. Consider the issue yours. Feel free to ping us if you a helping hand on it.

machi1990 on 3 Oct 2019

👍2

I still working on it, I just spend more time than I expected due to difficulties with integration tests.

lhauspie-adeo on 10 Oct 2019

👍1

@lhauspie or is it @lhauspie-adeo :-) it is okay, take the time you need. If you think you can use some help from the team, you can also open a draft PR so that others contributors/maintainers can look at it and give their inputs.

machi1990 on 10 Oct 2019

❤1

Damn! I miss clicked when choosing my github account :/

lhauspie on 17 Oct 2019

😄1

@lhauspie I you are still blocked you can open a PR and ask for help. When we have the code we will be able to help you.

loicmathieu on 17 Oct 2019

@loicmathieu, I think you know that it's mainly a planning issue. I've to work on an other subject, my deadline is tomorrow so I will continue to work on that issue tomorrow ;)

lhauspie on 17 Oct 2019

This is being done as part of #4520