Quarkus: Openshift - Configure logging to not write in a file

[cescoffier]

Because it requires specific permission in the CWD.
Ideally, this can be passed in the command line:

./app -Dlogfile=none

or something like that.

[geoand]

Since Quarkus is meant to be container first, wouldn't it make sense to not write to a file by default?

I mean one of the factors of the 12 factor app design is to log to stdout only.

[cescoffier]

I agree, we may change the default, and allow writing to file when the user
wants it.

On Thu 20 Dec 2018 at 10:01, Georgios Andrianakis [e-mail]
wrote:

Since Protean is meant to be container first, wouldn't it make sense to
not write to a file by default?

I mean one of the factors of the 12 factor app design is to log to stdout
only.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jbossas/protean-shamrock/issues/355#issuecomment-448923669,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYjff2MZNRrKSX0lXoENWrKJznMBwetks5u61HwgaJpZM4ZbsIP
.

[geoand]

:+1:

[dmlloyd]

Disabling the log file, and disabling the console, are both things that are configured by MP config already.

Our preferred logging approach will definitely be tailored to the execution environment, but that definitely is not always going to equal logging to stdout only I think. In some cases maybe yes, but in other cases the execution environment is going to want something different (e.g. fluentd). I'd hope we could do something slightly more tailored than a plain stdout-slurping at least.

[dmlloyd]

Passing -Dshamrock.log.file.enable=false should disable the log file; is that sufficient to address the initial issue?

[cescoffier]

Yes, it’s perfect!

On 7 Feb 2019, at 00:36, David M. Lloyd [e-mail] wrote:

Passing -Dshamrock.log.file.enable=false should disable the log file; is that sufficient to address the initial issue?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[gsmet]

@geoand do we need any action in the default Dockerfiles or whatever is used in OpenShift?

[geoand]

Yes, we would need to add that to the generated Dockefiles. I can open a PR for this tomorrow

[geoand]

@vorburger I assume this is something we need to add to the native s2i process as well?

[vorburger]

@geoand yup, and I have proposed that in #1599 if that's the conclusion of this issue's discussion...

... but I personally actually do also think that this is the wrong approach - the default of true of quarkus.log.file.enable seems wrong, to me, for a "Kubernetes Native Java stack" framework... IMHO default should be console, only; and log file should be opt-in (12 Factor).

-Dshamrock.log.file.enable=false

BTW: It's quarkus.log.file.enable and not shamrock.log.file.enable, right?? That's what doc'd.

[vorburger]

We should do something similar in https://github.com/quarkusio/quarkus-quickstarts/pull/81 (non-native S2I) ?

[geoand]

@vorburger I think we should. I am going to open a PR containing a fix only to the generated Dockerfiles

[geoand]

I added PR #1600 for the generated Dockerfiles

[dmlloyd]

FWIW disabling file logging by default is OK with me.

[vorburger]

FWIW disabling file logging by default is OK with me.

@dmlloyd I'm happy to raise the respective PR, but I have no idea where the default of quarkus.log.file.enable is defined in the sources... I cannot find it via a quick dumb grep. If you'd like to give me a hint/pointer, I could have a closer look.

[dmlloyd]

It's this line here: https://github.com/quarkusio/quarkus/blob/master/core/runtime/src/main/java/io/quarkus/runtime/logging/FileConfig.java#L31