Qtox: Make use of a normal Qt file chooser dialog

Created on 13 May 2018  路  10Comments  路  Source: qTox/qTox

To fix "https://github.com/flathub/flathub/pull/379#pullrequestreview-118545657", the usage of a normal Qt file chooser dialog is apparently needed to avoid the requirement for the "--filesystem=" flag in flatpak.

C-discussion M-packaging

Most helpful comment

I'm against this change, because the native dialog integrates much better with each platform. IMO we could look into making a compile/runtime switch for that and use it for the flatpaks, but for me it's not a high priority.

What do other people think?

All 10 comments

I'm against this change, because the native dialog integrates much better with each platform. IMO we could look into making a compile/runtime switch for that and use it for the flatpaks, but for me it's not a high priority.

What do other people think?

I agree that the native dialogue is better, we had an issue https://github.com/qTox/qTox/issues/3494 that made us switch to native dialogues recently, and before that switch I had a friend comment on the weird ugly file picker (Qt) on Windows. If it's not too much trouble to use native dialogues for flatpacks I think that's preferred, but I'm not really aware of what that would require

We should keep the native file picker. It never fails and is well integrated into the system.

@tox-user

It never fails

It's ~wrong)
See #3443 for the details

True, but it says the problem was only with Nautilus and only on Arch Linux.

When some other program fails it's not our fault.

For me personal "ugly" does not matter in this case, because you have to see the file picker only a small amount of time.
And if it is English instead of French, this sounds like a bug which should be reported at the proper places.

I don't know the policy at Flathub for using the "--filesystem=" flag, but in consideration of Sandboxing it does make sense to not use it, if it is not really required.

I don't know if this is a problem with the flatpak version of qTox, but I am not able to select a "Default directory to save files:" for "Autoaccept files" over the GUI?

screen

I don't know the policy at Flathub for using the "--filesystem=" flag, but in consideration of Sandboxing it does make sense to not use it, if it is not really required.

Apparently it is required by flathub to make things work. Rather than changing things in qTox, it sounds like flathub should be fixed to not cause problems over using native file picker.

Since everyone agrees that using shitty pile picker is a bad idea, this issue should be closed.

I don't know if this is a problem with the flatpak version of qTox, but I am not able to select a "Default directory to save files:" for "Autoaccept files" over the GUI?

That would be a separate issue. Lets have separate issues for separate problems to ease tracking whether they're properly addressed.

Since everyone agrees that using shitty pile picker is a bad idea, this issue should be closed.

Closing then.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Tcll picture Tcll  路  3Comments

tox-user picture tox-user  路  4Comments

ovalseven8 picture ovalseven8  路  4Comments

ghost picture ghost  路  4Comments

dcapeletti picture dcapeletti  路  4Comments