Qownnotes: Force close when opening a note: Visual C++ Runtime Library

[Primokorn]

Hello,
Back from vacation I've upgraded from v19.12.13 to v20.1.0. (.exe file launched on a Windows 7 computer).
I can no longer open a note (no issue with most notes). Here is the message I get then QOwnNotes is force closed:

Full code of the note here

Thanks in advance.

EDIT: log once the above pop-up is here

[pbek]

What happens if you run QOwnNotes in a new session, like QOwnNotes.exe --session test2020?

[pbek]

@Waqar144, this is also reproducible under Linux. It's a crash in the preview. If you turn the preview off the crash doesn't happen.

[Primokorn]

QOwnNotes.exe --session test2020

I copied the code and it works.

[pbek]

I copied the code and it works.

As long as you have no preview turned on, right?

[Primokorn]

Exactly.

[Waqar144]

It's access out of bounds probably.

Will fix it by tonight.

[pbek]

The crash happens in CodeToHtmlConverter::highlightComment and the note works until you add the 2nd last line * [IP lock](http://zend.snr.fr/technique/tools/serviceDesk/IncidentManagement/ticket/detail/id/518834).

[pbek]

But simply fixing the "access out of bounds" didn't help, because if the method returns a -1 you'll get into an infinite loop. :grin:

[Waqar144]

But simply fixing the "access out of bounds" didn't help, because if the method returns a -1 you'll get into an infinite loop. grin

Yeah but its really very much impossible to get a -1 out of there. :rofl:

The problem here is that it is trying to highlight text it shouldn't be. The reason is code blocks are kind of inline so it confuses the highlighter.

The highlighter works on the assumption that ``` is on a separate line.

[pbek]

Great, worked for me!

[Primokorn]

What's working? Do you expect new test from me?

[Waqar144]

Not yet.
@pbek is talking about the latest changes.

There will be a new release soon, then you will be able to test

[pbek]

20.1.1

• fixed possible crash for inline code blocks in preview highlighter
  (for #1532, thank you @Waqar144)

There now is a new release, could you please test it and report if it works for you?

[Primokorn]

Fixed, well done guys!

[pbek]

Great, thank you for testing!