Qownnotes: RTL editor text

[ron-popov]

Expected behaviour

When i would write text in the editor , it would appear (in the editor) as RTL.
I would be able to change it in the settings or simply changing the preview to RTL would change the editor as well.

Actual behaviour

It goes LTR

Steps to reproduce

Always

Output from the debug section in the settings dialog

Relevant log output (you have to enable enable the log widget)

[pbek]

Have you changed your font you a RTL font?

[ron-popov]

I tried a couple of different fonts (Ubuntu , Cantarell , DejavuSans) , and it didn't work.

[pbek]

The font has to support RTL, otherwise it will not work. Maybe @yousufinternet from #335 can help you.

[tareefdev]

I have a related problem here, the last version (17.09.4 - OBS - build 378) make my Arabic texts aligned to left (instead of right). but the direction of text is correct (RTL) ...the previous releases don't have this issue

[ron-popov]

Me too

[pbek]

The last release didn't contain anything that could cause this. Please
post a note file and a screenshot. I will then take a look at it.

Am 08.09.2017 16:05 schrieb "Ron Popov" [e-mail]:

Expected behaviour

When i would write text in the editor , it would appear (in the editor) as
RTL.
I would be able to change it in the settings or simply changing the
preview to RTL would change the editor as well.
Actual behaviour

It goes LTR
Steps to reproduce

Always
Output from the debug section in the settings dialog Relevant log output
(you have to enable enable the log widget)

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/pbek/QOwnNotes/issues/714, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtv1c_S0CC3YntQ0gPKhiom7VHy-_gRks5sgUmWgaJpZM4PROhG
.

[tareefdev]

You can see form this file how the Arabic text align to left
But the direction is RTL when I typed mixed words (Arabic&English)

QOwnNotes Debug Information.zip

[pbek]

I can't try it myself without the note file...
It may be related to https://bugreports.qt.io/browse/QTBUG-7516, can anyone confirm that?

[pbek]

The QPlainTextEdit went to work in version 17.09.1, see http://www.qownnotes.org/changelog/QOwnNotes.

[tareefdev]

I can't try it myself without the note file...

I'm sorry, this is the file
arabic note.txt

and this is how the same note looks like in Kate (and it's the proper way):

Thanks for being on the issue.

[pbek]

I tested it with version 17.09.1 (where the note edit was still based on QTextEdit) and it worked there. With the current version (with QPlainTextEdit) I have the same issue. It seems the Qt-bug is still persistent. :(

[tareefdev]

Thank you for your interest.

Can you provide me some links about why qownnote switch from QTextEdit to QPlainTextEdit?

[pbek]

Speed, QON never did rich text editing, I simply didn't know that QPlainTextEdit can also use the QSyntaxHighlighter (that I used to implement Markdown syntax highlighting).

http://www.qownnotes.org/changelog/QOwnNotes

Edit: plus QPlainTextEdit has some more features we can now use...

[tareefdev]

So, do you see it's a good idea to open an issue here?
https://github.com/pbek/qmarkdowntextedit

and the last thing :D can you provide me a rpm package for 17.09.1 version?

big thanks :)

[pbek]

Wouldn't make much difference, since it's my library for QOwnNotes.
What would make sense would be to post an issue at https://bugreports.qt.io/ (if it isn't an already existing one). The RTL-handling is done by QPlainTextEdit.

[tareefdev]

Ah! it's YOUR library too, I didn't notice that :D

Do you have any idea why programs like Kate/Kwrite don't have this issue? I need some help to write a helpful bug report.

[pbek]

They might simply use QTextEdit.
Maybe you can first research if a similar bug is already existing (maybe the one I posted above).

Hm, that's strange. I just tested with my test application in https://github.com/pbek/qmarkdowntextedit and I didn't get the problem there... I have to investigate more.

[pbek]

Stupid me, I checked out the old commit with QTextEdit. In the current code the problem is existing.

[pbek]

If there is no past Qt-issue you could create one and post a screenshot of your text in the plain text edit along with the text itself. I also get the problem in my Qt 5.9.1.

[pbek]

@tareefdev, I tested the issue with Qt's Code Editor Example from http://doc.qt.io/qt-5/qtwidgets-widgets-codeeditor-example.html and it had the same problem. You could use that information in your Qt bug-report. Thanks a lot for helping!

[pbek]

[pbek]

I commented on https://bugreports.qt.io/browse/QTBUG-7516

[tareefdev]

Thanks man. it's 7 years old bug :/

I don't think it would be solved soon.. however thank you again.

[pbek]

It's really bad, I don't know why QTextEdit doesn't have that bug and why so little people are complaining about it.

[pbek]

@tareefdev, great news, I think I was able to get around this Qt bug!

[pbek]

17.09.8

• fixed the upstream RTL bug in the note text edit

[pbek]

There now is a new release, could you please test it and report if it works for you?

[tareefdev]

Woooo that's amazing, great, wonderful
Thanks a lot for making a workaround for this bug, the app is really brilliant again

[pbek]

Great, thank you for testing! I wonder why this never got fixed.

[tareefdev]

I read your code snippet in qt Bug tracker and I hope this will help developers to solve the bug soon.