Qmk_firmware: NO_ACTION_TAPPING disables layers

Created on 29 Apr 2019  路  4Comments  路  Source: qmk/qmk_firmware

I was just playing around for fun, because I'm probably going to use taps at one point. But defining NO_ACTION_TAPPING disables the layer switching. Even with MO

bug core

Most helpful comment

I was running into this issue as well, Clueboard 66 Hotswap prototype (atmega32u4), NO_ACTION_TAPPING was defined by default for this keyboard, so I had to undef it to enable my MO() layer tapping as well as LT() layer switching.

All 4 comments

That's odd.

I can confirm that MO is disabled, but .... TG is not.

Oh, okay. MO is technically ACTION_LAYER_TAP((layer), OP_ON_OFF). So, we'd need to more finely ifdef it...

https://github.com/qmk/qmk_firmware/blob/c5221fa1cb1e903600205ba831c841f9d3aad33f/tmk_core/common/action.c#L457

Good to know, thought I went crazy for a minute 馃槉

I mean, crazy is always a possibility, but this is definitely an unintended effect.

I'll see about fixing this, if i can.

I was running into this issue as well, Clueboard 66 Hotswap prototype (atmega32u4), NO_ACTION_TAPPING was defined by default for this keyboard, so I had to undef it to enable my MO() layer tapping as well as LT() layer switching.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

BenRoe picture BenRoe  路  3Comments

helluvamatt picture helluvamatt  路  4Comments

ghost picture ghost  路  3Comments

MarkuBu picture MarkuBu  路  3Comments

matz-e picture matz-e  路  4Comments