Qmk_firmware: Rotary Encoder not working with Pro Micro

[BenRoe]

I try to get the encoder working on a breadboard with a Pro Micro. Added the code from feature_encoders.md and use the Pins PD1 (2) & PD4 (4).

Describe the bug

The key is not triggered if i rotate the encoder.

System Information

• Keyboard: Breadboard
  
  
  
  • Revision (if applicable):
  
  
• Operating System: Windows 10

Full code
https://github.com/BenRoe/qmk_firmware/tree/breadboard-test/keyboards/breadboard

If i use the code from https://github.com/and3rson/qmk_firmware/tree/master/keyboards/lets_split/keymaps/anderson
Everything works.

[nooges]

I ran into the same issue with 32u4, if I change the lines in encoder.c involving readPin() by casting to bool as follows, the encoder works:

Old: (readPin(encoders_pad_a[i]) << 0) | (readPin(encoders_pad_b[i]) << 1)

New: ((bool)readPin(encoders_pad_a[i]) << 0) | ((bool)readPin(encoders_pad_b[i]) << 1)

[nooges]

Should be fixed now that https://github.com/qmk/qmk_firmware/pull/4681 has been merged in.

[BenRoe]

Tried it today, but still not working.