Qiskit-terra: More test for the Quaternions

Created on 30 Nov 2018  路  6Comments  路  Source: Qiskit/qiskit-terra


What is the expected behavior?

After the pr #1383 I noticed we have very few tests on the Quaternions. We should fix this in a followup PR.

good first issue
Source
picture jaygambetta

All 6 comments

@jaygambetta @1ucian0 I am new to this repo but if it's alright with you, I would love to take on this issue.

npdeep picture npdeep on 15 Feb 2019
🎉1

sounds great.

jaygambetta picture jaygambetta on 15 Feb 2019
👍1

any update @npdeep ?

1ucian0 picture 1ucian0 on 8 Apr 2019

Been distracted with travels lately. I will try to make a PR by this weekend.

npdeep picture npdeep on 8 Apr 2019
👍1

@jaygambetta @1ucian0 I have made a PR (https://github.com/Qiskit/qiskit-terra/pull/2123) with a couple of more tests. Would appreciate some feedback. Please do let me know if there are any low-lying tests I am missing.

npdeep picture npdeep on 13 Apr 2019

Closed via https://github.com/Qiskit/qiskit-terra/pull/2123

1ucian0 picture 1ucian0 on 15 Apr 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

cbjuan picture cbjuan  路  3Comments
ewinston picture ewinston  路  3Comments
1ucian0 picture 1ucian0  路  6Comments
ajavadia picture ajavadia  路  7Comments
ajavadia picture ajavadia  路  5Comments