Pytorch: [v1.7.0] Release Tracker

[seemethere]

We cut a release branch for the 1.7.0 release.

Our plan from this point is roughly:

• Phase 1 (until 10/13): work on finalizing the release branch
• Phase 2 (after 10/13): perform extended integration/stability/performance testing based on Release Candidate builds.

This issue is for tracking cherry-picks to the release branch.

Cherry-Pick Criteria

Phase 1 (until 10/13):

Only low-risk changes may be cherry-picked from master:

1. Fixes to regressions against PyTorch 1.0+
2. Critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks
3. Fixes to new features being introduced in this release
4. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries
5. Test/CI fixes or improvements
6. Documentation improvements
7. Release branch specific changes (e.g. change version identifiers, remove/hide features that aren’t ready for release)

Any other change requires special dispensation from the release managers (currently @malfet, @seemethere, @gchanan). If this applies to your change please write "Special Dispensation" in the "Criteria Category:" template below and explain.

Phase 2 (after 10/13):

Note that changes here require us to rebuild a Release Candidate and restart extended testing (likely delaying the release). Therefore, the only accepted changes are:

_Release-blocking_ critical fixes for: silent correctness, backwards compatibility, crashes, deadlocks, (large) memory leaks

This will likely require a discussion with the larger release team over VC or Slack.

Cherry-Pick Process

1. Ensure your PR has landed in master. This does not apply for release-branch specific changes (see Phase 1 criteria).

2. Create (but do not land) a PR against the release branch. Note that you should use the normal github workflow for this; ghstack does not support release branches.

3. Make a request below with the following template:

Link to landed master PR (if applicable):
Link to release branch PR:
Criteria Category:

1. Someone from the release team will reply with approved / denied or ask for more information

2. If approved, someone from the release team will merge your PR once the tests pass. NOTE: do not land the release branch PR yourself. Our normal landing tools (ghimport, phabricator, etc.) do not work on the release branch.

[zou3519]

_Link to landed master PR (if applicable):_ n/a, release-specific change
_Link to release branch PR:_ https://github.com/pytorch/pytorch/pull/45571
_Criteria Category:_ Release branch specific changes: remove/hide features that aren’t ready for release

---

@seemethere: accepted

[Krovatkin]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45546
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45591
Criteria Category: special dispensation : Profiling Executor and Tensor Expressions are two features that shareholders (@soumith, @ngimel, @dzhulgakov etc) decided should go into 1.7. Unfortunately, we narrowly missed the deadline fixing a small oversight in one of the test configurations.

--
@malfet: merged

[anjali411]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/45461
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45602
Criteria Category: silent correctness. Before this branch, the functions unaudited for complex backward returned incorrect result. After this PR, a RuntimeError is thrown in forward clearly stating that complex backward is not supported for the operator yet.

--
@malfet: merged

[suo]

Link to release branch PR: https://github.com/pytorch/pytorch/pull/45628
Criteria category: Release branch specific changes: remove/hide features that aren't ready for release.

--
@malfet: merged

[jamesr66a]

Link to release branch PR: https://github.com/pytorch/pytorch/pull/45631
Criteria Category: Release branch specific changes: remove/hide features that aren’t ready for release

--
@malfet: merged

[robieta]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/45586
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45601
Criteria Category: special dispensation : Callgrind collection is an important aspect of the benchmarking utils beta launch. (CC @ngimel @ezyang @dzhulgakov) Original PR narrowly missed the cut, and had to be reverted and re-landed today due to a test breakage. Fortunately it is isolated to benchmark utils and as a result the interaction radius should be small.

---

@malfet: Binary size diff is less than 4Kb, merged.

[mrshenli]

Link to landed master PR: #45553
Link to release branch PR: #45738
Criteria Category: Documentation improvements: Advise users to use a more widely-adopted conda channel and pin the libuv version to the one that we have tested (1.39).

--
@malfet: merged

[mrshenli]

Link to landed master PR: #45554
Link to release branch PR: #45739
Criteria Category: Fixes to new features being introduced in this release: Make sure that users don't have to install libuv if they don't need the distributed package.

--
@malfet: merged

[QueensGambit]

Link to release master PR: #45736
Criteria Category: Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries

--
@malfet: Please land it in master first

[BowenBao]

Link to landed master PR: #44920
Link to release branch PR: #45755
Criteria Category: Fixes to new features being introduced in this release: Fix dim_param support for ONNX export with shape inference, along with fixes to shape propagation bugs in other code that are discovered. This PR is crucial for ONNX export in 1.7, unfortunately it missed the cut by a few hours.

--
merged

[neginraoof]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/44693
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45756
Criteria Category: Fixes ONNX export of embedding bag operator with dynamically provided arguments: offsets and weights. Enables ONNX export of DLRM model. This PR is crucial for ONNX export in 1.7.

--
merged

[osalpekar]

Link to landed master PR: #45543
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45758
Criteria Categrory: Documentation - PyTorch Distributed exposes a Python API for a distributed key-value store, but there were no public docs for this. This PR adds those public docs.

--
@malfet: merged

[bdhirsh]

Link to landed master PR (if applicable): #45587 and #45588
Link to release branch PR: #45759
Criteria Category: Fixes to new features being introduced in this release: Un-defaulting a new parameter to the smooth_l1_loss_backward function, which is how we handle all other backwards function inputs and would otherwise require deprecating. Fixed some incorrect changes to the documentation of smooth_l1_loss.

---

@malfet: resolved merged conflict, waiting for CI
@gchanan: merged

[xwang233]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45729
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45770
Criteria Category: Fixes to new features being introduced in this release.

A user just reported seeing this https://github.com/pytorch/pytorch/issues/45769. It would be nice that we have this minor information printing bug be fixed in the release.

--
@malfet: merged

[anjali411]

Link to landed master PR: N/A
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45839
Criteria Category: silent correctness. Disabled backward for torch.angle.

--
@malfet: merged

[gchanan]

Link to landed master PR: N/A
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45859
Criteria Category: Release branch specific changes -- makes the compatibility tests pass against 1.6.0.

---

Merged

[xta0]

Link to landed master PR: #45651, #45677, #45798
Link to release branch PR: #45891
Criteria Category:[iOS][CI]

1. Fix the iOS dev cert issue for CI jobs and nightlies.
2. Solve the XCode12 user issue - https://github.com/pytorch/pytorch/issues/44143

--
@malfet: merged

[vkuzo]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/45848
Link to release branch PR: https://github.com/pytorch/pytorch/commit/ebe8b21b089ac75f053a67b5a980fce93a289d01
Criteria category: Documentation improvements - adds an API summary to the Quantization documentation

Working with @malfet to figure out how this ended up merged without a PR, I probably messed up a git step.

[xwang233]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45889
Link to release branch PR: https://github.com/pytorch/pytorch/pull/45924
Criteria Category: 4. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries

This may improve the performance on Ampere GeForce 3080 and 3090, if pytorch is compiled with cuda 11.1.

--
@malfet: this sounds a bit vague, can you please share some benchmark results?

[zasdfgbnm]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/46001
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46042
Criteria Category: 2. Critical fixes for silent correctness https://github.com/pytorch/pytorch/issues/45724

---

@malfet: merged

[adampauls]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/43532
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46014
Criteria Category:4. Compilation fixes or ifdefs required for different versions of the compilers or third-party libraries

[t-vi]

Once it's landed, probably https://github.com/pytorch/pytorch/pull/46028 (high priority bug fix, should apply to 1.7 as well)

[malfet]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/45914
Link to release brnch PR: https://github.com/pytorch/pytorch/pull/46039
Criteria Category: 3 or 5 - Speeds up checkout time

---

@seemethere: merged

[anjali411]

Link to landed master PR: #45270
Link to release PR: #46072
Criteria: Documentation (Complex Autograd doc note)

--
@malfet: merged

[SplitInfinity]

Link to landed master PR: #45559
Link to release PR: #46060
Criteria: Fixes to new features (JIT support for torch.no_grad being introduced in this release)

--
@malfet: merged

[pritamdamania87]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45642
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46073
Criteria Category: Critical fixes for: crashes: Using ProcessGroupNCCL without GPUs would result in a crash without this fix.

--
@malfet: merged

[wanchaol]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/45871
Link to release PR: https://github.com/pytorch/pytorch/pull/46071

Criteria: critical fixes to new prototype features (distributed compilation concurrent compilation in multithreaded environment)

---

@malfet: merged, after clarifying fix reliability

[rohan-varma]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45933
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46099
Criteria Category: Fixes to regressions against PyTorch 1.0+: Previously, DDP would report an error recommending users set find_unused_parameters=True when there is an error due to unused parameters in the model. This regressed due to https://github.com/pytorch/pytorch/pull/44798, and this cherry pick fixes that regression.

--
@malfet: merged

[neginraoof]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/45874
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46100
Criteria Category: [ONNX] Improves error handling for ONNX exporter for scripting unsupported ops.

--
@malfet: merged

[albanD]

Link to landed master PR: None yet as there is some fb internal changes that are trickier to do
Link to release branch PR: #46103
Criteria Category: This op is not documented or tested so we shouldn't have it in the release.

@gchanan Release branch specific changes.

--
@malfet: merged

[eellison]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/45857, https://github.com/pytorch/pytorch/pull/45929
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46105
Criteria Category: critical fixes for silent correctness issue

--
@malfet: merged

[rohan-varma]

Link to landed master PR (if applicable): #46075
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46109
Criteria Category: Documentation improvements: We have implemented these APIs, but are still iterating on them. Thus, removes these from public docs for now. Will add them back when these APIs are part of a formal release.

--
@malfet: merged

[mrshenli]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/46220
Link to release PR: https://github.com/pytorch/pytorch/pull/46366
Criteria Category: Documentation improvements: This is NOOP change to track usages of ProcessGroup::Work API methods that are to be deprecated (BC breaking) in the following release

---

@malfet: merged

[gchanan]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45915
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46114
Criteria Category: Test/CI fixes or improvements

I don't think we _technically_ need this, but it's necessary for a backport of https://github.com/pytorch/pytorch/pull/46036 to apply cleanly.

--
@malfet: merged

[mruberry]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45802
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46177
Criteria Category: fix for silent correctness issue (https://github.com/pytorch/pytorch/issues/45721)

--
@malfet: merged

[malfet]

Link to landed master PR: #45004
Link to release branch PR: #46206
Criteria Category: Regression from previous release

---

merged

[malfet]

Link to landed master PR: #46036
Link to release branch PR: #46207
Criteria Category: Fixes for silent correctness issue

---

merged

[nickgg]

Link to landed master PR (if applicable): #46129
Link to release branch PR: #46214
Criteria Category: Correctness fixes for Half types in NNC based fuser (#45953 )

---

@malfet: merged

[vkuzo]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46077
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46217
Criteria Category: silent correctness (fixes numerics for NHWC in QNNPACK for tanh, hardsigmoid, sigmoid)

---

@malfet: merged

[gchanan]

Link to landed master PR (if applicable): N/A
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46262
Criteria Category: Release branch specific changes

---

@malfet: merged

[anjali411]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46258
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46281
Criteria Category: Doc fix

---

@malfet: merged

[jeffdaily]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/46097
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46323
Criteria Category: Significant performance regression from previous release, ROCm-only

---

@malfet: merged

[gchanan]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45782
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46333
Criteria Category: Test/CI fixes or improvements

should allow ROCm tests to pass.

---

@malfet: merged

[Flamefire]

Link to landed master PR (if applicable): #46186
Link to release branch PR: #46385
Criteria Category: Test/CI fixes or improvements

Fix for test_rnn in test/distributed/test_c10d_spawn.py

---

@malfet: Test only change, merged

[Flamefire]

Link to landed master PR (if applicable): #46315
Link to release branch PR: #46388
Criteria Category: Test/CI fixes or improvements

Avoid error when using Python 3.9 (e.g. clang-tidy CI)

---

@malfet: merged and thank you for the pick

[albanD]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/46406
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46407
Criteria Category: Mitigation for https://github.com/pytorch/pytorch/issues/46242 that replaces the internal error by a helpful message.

[albanD]

Link to landed master PR (if applicable): #46397
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46408
Criteria Category: Fix wrong error message content for torch.scatter. It is a nice to have but not strictly needed.

---

Merged

[gchanan]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/46335
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46418
Criteria Category: Test/CI fixes or improvements. Should allow clang-tidy to pass on release branch.

---

Merged

[gchanan]

Link to landed master PR (if applicable): https://github.com/pytorch/pytorch/pull/45638
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46419
Criteria Category: Test/CI fixes or improvements. Should fix cuda fuser test failures on release branch.

---

Merged

[SplitInfinity]

Link to landed master PR: #45940
Link to release branch PR: #46422
Criteria category: Fix for a crash in an uncommonly used user-facing code path in TorchScript

---

@malfet: merged

[gchanan]

Link to landed master PR: N/A
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46425
Criteria category: Release branch specific changes, fix CI for XLA.

---

Merged

[robieta]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46023
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46403
Criteria category: Special Dispensation several key tweaks to benchmark utils.

[ZolotukhinM]

Link to landed master PR: #46446
Link to release branch PR: #46453
Criteria category: fixes a crash

[gchanan]

Link to landed master PR: N/A
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46478
Criteria category: Release branch specific changes, fix CI for backwards compatibility

---

merged

[Krovatkin]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46479
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46621
Criteria category: Critical fixes (increased memory consumption in profiling mode)

---

@malfet: merged

[ZolotukhinM]

Link to landed master PR: #46446, #46500, #46482
Link to release branch PR: #46513 (combines all three commits)
Criteria category: fixes incorrect behavior in fused aten::cat

---

@malfet: merged

[suo]

Link to release branch PR: https://github.com/pytorch/pytorch/pull/46556
Link to master PR: https://github.com/pytorch/pytorch/pull/46556
Criteria category: fixes test breakage when built with BUILD_TEST=0 (which the RC builds do)

---

@malfet: Please create this change in master first, as it is not specific to RC PRs

[albanD]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46673
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46718
Criteria category: Remove public functions that should not be public called valgrind_*.

---

@malfet: merged

[albanD]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46680
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46719
Criteria category: Remove public functions that should not be public for __torch_function__ feature

---

@malfet: merged

[albanD]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46676
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46765
Criteria category: Remove public functions that should not be public add_relu.

---

@malfet: merged

[brianjo]

Link to release branch PR: #46845
Criteria category: Documentation improvements.

[osalpekar]

Link to landed master PR: https://github.com/pytorch/pytorch/pull/46856
Link to release branch PR: https://github.com/pytorch/pytorch/pull/46879
Criteria category: Docs fixes

[z-a-f]

Link to landed master PR: #46858
Link to release branch PR: #46890
Criteria Category: Documentation improvement: Quantization docs had a specific version to describe unsupported features. Changed to more general wording.

[seemethere]

Hey everyone, 1.7.0 has been released so I'm going to close this.

Thank you everyone for the work towards getting v1.7.0 out of the door!

[z-a-f]

Link to landed master PR: #46858
Link to release branch PR: #46890
Criteria Category: Documentation improvement: Quantization docs had a specific version to describe unsupported features. Changed to more general wording.

@seemethere If this PR was not merged, is there still a way to add it?