pytest 3.9.1 - tmpdir_factory not creating symlink to latest run

[mulawamichal]

hi,

on previous pytest (3.8.2 and earlier) when using a tmpdir_factory fixture it was creating subsequent directories for each of runs in pytest-of-$USER and a symlink to most recent one like this:

foobar@foobar:~$ ll /tmp/pytest-of-foobar/
total 56
drwxr-xr-x  5 foobar foobar  4096 Oct 17 09:23 .
drwxrwxrwt  5 root   root   36864 Oct 17 09:23 ..
drwxr-xr-x 14 foobar foobar  4096 Oct 17 09:19 pytest-0
drwxr-xr-x  4 foobar foobar  4096 Oct 17 09:20 pytest-1
drwxr-xr-x  4 foobar foobar  4096 Oct 17 09:24 pytest-2
lrwxrwxrwx  1 foobar foobar    30 Oct 17 09:23 pytest-foobar -> /tmp/pytest-of-foobar/pytest-2

On latest pystest (3.9.1) the symlink is not getting created - which is a HUUUUUGE issue for me.

[RonnyPfannschmidt]

@pytest-dev/core i have to apologize - in my current setup i managed to accidentally push to master

[RonnyPfannschmidt]

i rectified the local situation for future use by setting up git remote set-url upstream --push no_push

[nicoddemus]

It happens, don't worry! Thanks for fixing this up so quickly! 👍

[dmitrytokarev]

@RonnyPfannschmidt when setting up protected branch include administrators then don't have to worry for any "local setup":

[nicoddemus]

@dmitrytokarev ahh good idea, just updated the configuration, thanks!

[asottile]

damn, ya got me -- now I can't https://github.com/pytest-dev/pytest/commit/ab8907f6f5b7a0d9df645651dbb34732b775b9cb

[nicoddemus]

😬