Pytest: config.fromdictargs applies the dictionary after the config object construction instead of

Created on 20 Jul 2016  路  6Comments  路  Source: pytest-dev/pytest

this results in inconsistent/strange behaviour wrt tmpdir, on more than 3 nodes
and inconsistent pluginmanager initialization

critical backward compatibility bug

Most helpful comment

thats also my impression

All 6 comments

I see what you mean @RonnyPfannschmidt. I guess it is a simple fix: get_config receives an optional options dict which is forwarded to the Config constructor.

Do you plan to work on this? Feels like a good change to go into 3.0.

i took a initial look and this might turn bigger han expected to end with something thats correct instead of barely passing our tests

Hmm OK, bummer. But do you still intend to work on it?

yes, but im not sure if it can make it into 3.0

i wonder if its ok to make it into 3.1

I think going into 3.1 is fine, no need for 4.0 I mean

thats also my impression

Was this page helpful?
0 / 5 - 0 ratings