Pysyft: Reciprocal test enchantment negative numbers

Created on 20 Aug 2020  路  4Comments  路  Source: OpenMined/PySyft

Description

Test the reciprocal method from precision using negative numbers

Expected Behavior

All tests are passing

Screenshots

If applicable, add screenshots to help explain your problem.

Additional Context

It might require changes to the reciprocal method

Good first issue Type
Source
picture gmuraru

Most helpful comment

I guess the Log and NR method are a problem. Division works fine.. Will look into the issue

Also, there might be worth checking out how CrypTen is doing - if they take into consideration negative values.

If not, one idea (it might not be the greatest) is to use symmetry.

picture gmuraru on 20 Aug 2020
👍2

All 4 comments

I guess the Log and NR method are a problem. Division works fine.. Will look into the issue

addy369 picture addy369 on 20 Aug 2020
👍1

Adding you :)

gmuraru picture gmuraru on 20 Aug 2020

I guess the Log and NR method are a problem. Division works fine.. Will look into the issue

Also, there might be worth checking out how CrypTen is doing - if they take into consideration negative values.

If not, one idea (it might not be the greatest) is to use symmetry.

gmuraru picture gmuraru on 20 Aug 2020
👍2

hey could you review my PR?
https://github.com/OpenMined/PySyft/pull/4065

addy369 picture addy369 on 22 Aug 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

aristizabal95 picture aristizabal95  路  3Comments
mgale694 picture mgale694  路  3Comments
beatrizsmg picture beatrizsmg  路  4Comments
wentaiwu92 picture wentaiwu92  路  4Comments
durden62 picture durden62  路  3Comments