Pysyft: All tests calling start_proc fail on windows

Created on 13 Jun 2019 · 6Comments · Source: OpenMined/PySyft

Describe the bug
Start proc does not succeed on windows causing 9 tests to fail
To Reproduce
Call make test on windows

Expected behavior
Tests should work on all operating systems
Desktop (please complete the following information):

OS: windows
Version: all

Additional context

-.txt

Help Wanted Status Type

Source

robert-wagner

All 6 comments

I would like to take this up if this is still available.

amit-rastogi on 9 Jul 2019

👍1

On Windows the web socket client also fails to connect giving the error below.

OverflowError: timeout doesn't fit into C timeval

Appears to be due to the timeout interval (TIMEOUT_INTERVAL = 9_999_999) specified in websocket_client.py.

amit-rastogi on 9 Jul 2019

👍1

I saw the PR "[WIP] Implement start_remote_worker #2345" where its mentioned that start_proc would get replaced with start_remote_worker. Hence, wanted to check if this issue is still valid and needs to be worked upon?

amit-rastogi on 12 Jul 2019

Hey @amit-rastogi,

The new function actually uses start_proc, so yes, this issue is still valid.

mari-linhares on 13 Jul 2019

👍1

The web socket client overflow error on windows has been addressed by https://github.com/OpenMined/PySyft/pull/2395

amit-rastogi on 27 Jul 2019

This issue has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the stale label to unmark it. Otherwise, this will be closed in 7 days.