Pysyft: Add Jupyter Notebooks to Unit Tests (Travis)

Created on 12 Apr 2019  路  10Comments  路  Source: OpenMined/PySyft

It would be great if we could add the notebooks to Travis so that they are automatically run (at least the notebooks we want to test). This would help us know when changes to the codebase break demos.

Good first issue

All 10 comments

I think I even wrote about this on Slack a few months ago. I'd like to get involved in development again. Can I take this one?

I don't t remember what @replomancer wrote , but one way of doing this is to have a bash script run first that find all jupyter notebooks and runs jupyter convert ... The command to convert jupyter notebooks to Python script and run the Python scripts as unit tests.

@replomancer you may go ahead. it's a much required feature right now and it would be great to have your help :)

Allright! I'm on it.

@replomancer are you still working on it?

@iamtrask would you mind to assign me to this one. I am back and happy to bring it to reality :)

I think we're about to merge it https://github.com/OpenMined/PySyft/pull/2755

But welcome back @lc0 !!! Great to see you!

I think we're about to merge it #2755

This is great. In this case, I would rather allocate my effort reviewing / improving existing one. Thanks for quick reply!

Added in #2755.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

iamtrask picture iamtrask  路  3Comments

mgale694 picture mgale694  路  3Comments

deevashwer picture deevashwer  路  4Comments

gmuraru picture gmuraru  路  4Comments

aristizabal95 picture aristizabal95  路  3Comments